Bazaar 2.2b2 install fails, Vista SP2 x64

Bug #569077 reported by Perry
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Bazaar Windows Installers
Fix Released
High
Gary van der Merwe
TortoiseBZR
Invalid
Undecided
Unassigned

Bug Description

Because Bazaar 2.1.1 appears to be unusable with repositories access across the network on Windows (bug report already exists and is diagnosed as a bzr core issue), I just attempted to install bazaar 2.2b2.

The install failed, with an error creating a temporary file, but the filename was blank.

I manually typed out the entire contents of the error message in a notepad file, but then at the end of the Install, it prompted to reboot, and did not prompt to save the file, so I lost all the text (that was surprising; Windows should prompt for unsaved notepad files, in my experience).

I have no TortoiseBazaar context menus, so I deduce that the install failed.

However, I do have bazaar 2.2b2 as an entry in my Add/Remove Programs & Features, so it is partially installed.

I will uninstall it. I could retry installing it, to capture the exact error message, if that would help?

Otherwise I will attempt to go back to a previous stable version before 2.1.1; I still have an older stable version installed on another client, and it is working with repositories on network shares, so I know of a working version to which to roll back.

Related branches

Revision history for this message
Perry (perryrapp) wrote :

I did find my failed install notes:

   Install failed: Runtime Error (at 9:666):
    Internal error: ExtractTemporaryFile: The file "" was not found.

I have since uninstalled (2.2b2) (no errors), rebooted, downloaded it again (bzr-2.2b2-setup.exe), and installed it again. This time it gave no errors. NB: This time I did not have a previous version installed.

However, I again have no TortoiseBzr menus. I'll repeat the install again to see if that was an option that I need to manually check.

Revision history for this message
Vincent Ladeuil (vila) wrote :

Thanks a lot for the feedback !
2.2.b2 is a beta version so your information is very valuable.
I've assigned the bug to the bzr-windows-installer.

affects: bzr → bzr-windows-installers
Changed in bzr-windows-installers:
importance: Undecided → High
status: New → Incomplete
Revision history for this message
Perry (perryrapp) wrote :

Uninstalled successfully, rebooted, installed 2.2b2 again, making sure to turn on TortoiseBazaar (Explorer Clients or some such label) this time. This time the install failed with the same message as above. Also I have no TortoiseBzr explorer menus.

So new hypothesis: The tortoiseBazaar portion of the install is failing.

Evidence in favor: Install succeeded when I did not elect the TortoiseBazaar option.

Revision history for this message
Perry (perryrapp) wrote :

New tests just performed greatly strengthen evidence for hypothesis that install failure is in TortoiseBazaar:

* XPSP3 x86 nearly brand-new vms
 - Installing bazaar 2.2b2 from scratch w/o selecting Tortoise succeeds.
 - Installing bazaar 2.2b2 from scratch with TortoiseBazaar fails with ExtractTemporaryFile error (as above)

 * VistaSP2 x86 nearly brand-new vms
 - Installing bazaar 2.2b2 from scratch w/o selecting Tortoise succeeds.
 - Installing bazaar 2.2b2 from scratch with TortoiseBazaar fails with ExtractTemporaryFile error (as above)

* VistaSP2 x64 nearly brand-new vms
 - Installing bazaar 2.2b2 from scratch w/o selecting Tortoise succeeds.
 - Installing bazaar 2.2b2 from scratch with TortoiseBazaar fails with ExtractTemporaryFile error (as above)

Changed in bzr-windows-installers:
status: Incomplete → Confirmed
Revision history for this message
methane (songofacandy) wrote : Re: [Bug 569077] Re: Bazaar 2.2b2 install fails, Vista SP2 x64

I get a log of inno setup.

TortoiseBZR can't start because of pipeline plugin raises
DependencyNotPresent Exception
because of "launchpadlib" is not present. ('plugins/launchpad' exists,
but 'launchpadlib' doesn't
exists)

After removing pipeline from plugins directory, TBZR can run normally.
# TortoiseBZR should ignore exception when loading plugins.

I can't find what causes error.

Revision history for this message
methane (songofacandy) wrote :

I think this exception caused by:
// [[[cog
// if "TBZR" in os.environ:
// import os
// cog.outl("if IsWin64 then")
// cog.outl(" tovmsi := '%s'" % os.path.basename(os.environ["TORTOISE_OVERLAYS_MSI_X64"]))
// cog.outl("else")
// cog.outl(" tovmsi := '%s'" % os.path.basename(os.environ["TORTOISE_OVERLAYS_MSI_WIN32"]))
// else:
// cog.outl("tovmsi := '';")
// ]]]
// [[[end]]]
            ExtractTemporaryFile(tovmsi);
            fqtovmsi := AddBackslash(ExpandConstant('{tmp}')) + tovmsi;
            params := '/i "' + fqtovmsi + '" /qn /norestart';
            if not ShellExec('', 'msiexec.exe', params, '', SW_HIDE,
                             ewWaitUntilTerminated, ErrorCode) then
                MsgBox('Failed to install TortoiseOverlays: ' + SysErrorMessage(ErrorCode),
                        mbInformation, MB_OK);
            // Ideally we could be bzr_postinstall.exe this way too, but
            // its needed at uninstall time.
        end;
        // cause explorer to re-fetch handlers.
        SHChangeNotify(SHCNE_ASSOCCHANGED, SHCNF_IDLIST, 0, 0);
    end;
end;

Is tortoiseoverlays packaged successfully?

Revision history for this message
Ian Clatworthy (ian-clatworthy) wrote :

Naoki,

There may well be some issues in how TortoiseBZR is packaged by the new scripts. Also note that cog is no longer used by the build process.

Revision history for this message
methane (songofacandy) wrote :

I've tested new issgen.py.

In generated bzr.iss:

            if IsWin64 then
                tovmsi := ''
            else
                tovmsi := ''

In template/inno/bzr.iss:
            {% if tbzr -%}
            if IsWin64 then
                tovmsi := '{{ tbzr_msi64_basename }}'
            else
                tovmsi := '{{ tbzr_msi32_basename }}'
            {% else -%}

This should be:
            {% if tbzr -%}
            if IsWin64 then
                tovmsi := '{{ tbzr_msi64 }}'
            else
                tovmsi := '{{ tbzr_msi32 }}'
            {% else -%}

Changed in bzr-windows-installers:
assignee: nobody → Gary van der Merwe (garyvdm)
status: Confirmed → Fix Committed
methane (songofacandy)
Changed in tortoisebzr:
status: New → Invalid
Revision history for this message
Perry (perryrapp) wrote :

Do you know if this is fixed in the 2.2.1 release listed here: http://wiki.bazaar.canonical.com/WindowsDownloads

?

(I don't see any date on the 2.2.1 releases on that page, so I don't know whether they are new or old.)

Revision history for this message
Perry (perryrapp) wrote :

(PS: It was unfortunate of me not to list some location info for the bzr core issue with windows networking, to which I alluded above, because now I'm having trouble finding it; I should have left a link or bug# or something.)

Revision history for this message
Alexander Belchenko (bialix) wrote :

@Perry, according to all comments this issue was fixed in 2.2b4. So bzr 2.2.1 should contain this fix as well.

Changed in bzr-windows-installers:
status: Fix Committed → Fix Released
Revision history for this message
Perry (perryrapp) wrote :

Just installed 2.2.1 successfully on Vista x64, which seems to help confirm that it is fixed in this release.

Revision history for this message
Alexander Belchenko (bialix) wrote :

Perry пишет:
> Just installed 2.2.1 successfully on Vista x64, which seems to help
> confirm that it is fixed in this release.
>
Thank you.

--
All the dude wanted was his rug back

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.