builder wanders to the wildness when building is finished

Bug #577247 reported by Fencer
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
High
Nicolai Hähnle

Bug Description

When a building is finished the builder doesn't use its flag to leave but wanders through the wildness and searches for a street.

Tags: builder flag way
Revision history for this message
Nasenbaer (nasenbaer) wrote :

I can confirm this bug -> regression

Changed in widelands:
status: New → Confirmed
importance: Undecided → High
milestone: none → build16-rc1
Revision history for this message
Nicolai Hähnle (nha) wrote :

Should be fixed in rev5355

Changed in widelands:
assignee: nobody → Nicolai Hähnle (nha)
status: Confirmed → Fix Committed
Revision history for this message
Sigra (sigra) wrote :

The "fix" has the side effect that the builder will see with the building's vision range for an instance. This may not be the intended behaviour. It is probably intended that for example a militarysite will only start seeing when the first soldier moves in. That is why the builder was not moved into the finished building.

It used to work fine that the builder just fugitated and looked for the closest flag connected to a warehouse, which was usually the building's flag (and maybe sometimes another one really close). And if the building's flag is no longer connected to a warehouse, the "fix" will not work either. The builder will get lost then as far as I understand.

If a fugitating builder will not find from the constructionsite to its flag but wanders off somewhere, that must be another regression.

Revision history for this message
Nicolai Hähnle (nha) wrote :

Well, the fugitive code has been changed to see further, so that fugitives have a higher chance of returning home, but there is a chance that they don't choose the closest flag. If the construction site is not connected to a flag, the builder will automatically become a fugitive anyway, similar to soldiers leaving their sites. Though you're right that the fix was not really complete in that case.

Anyway, I've just hacked around the see_area issue in Building now, and I've fixed the gowarehouse task so that it always properly leaves a building.

Revision history for this message
SirVer (sirver) wrote :

Released in build16-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.