Bazaar GTK+ Frontends

gcommit crashes in svn working copy

Bug #583554 reported by zsquareplusc
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar GTK+ Frontends
Fix Released
Low
Jelmer Vernooij

Bug Description

i have a svn working copy. I know this is not a typical use case and i do not really need it but i noticed the following:

- bzr qcommit correctly shows the commit dialog and changed files.
- bzr gcommit crashes with a Python traceback because some method in BranchConfig class is not available (see attachment for details)

What I would expect:
option 1) perform the operation as expected as the qbzr GUI can do it too
option 2) print an error message if the repository format is not appropriate but do not show crash reports

This bug report probably affects bzr-gtk or bzr-svn, not the bzr-core.

Related branches

lp:bzr-gtk/gtk2
Revision history for this message
zsquareplusc (zsquareplusc) wrote :
Revision history for this message
Alexander Belchenko (bialix) wrote :

Traceback:
 Traceback (most recent call last):
   File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 853, in exception_to_return_code
     return the_callable(*args, **kwargs)
   File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 1055, in run_bzr
     ret = run(*run_argv)
   File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 661, in run_argv_aliases
     return self.run_direct(**all_cmd_args)
   File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 665, in run_direct
     return self._operation.run_simple(*args, **kwargs)
   File "/usr/lib/python2.6/dist-packages/bzrlib/cleanup.py", line 122, in run_simple
     self.cleanups, self.func, *args, **kwargs)
   File "/usr/lib/python2.6/dist-packages/bzrlib/cleanup.py", line 156, in _do_with_cleanups
     result = func(*args, **kwargs)
   File "/usr/lib/python2.6/dist-packages/bzrlib/plugins/gtk/commands.py", line 293, in run
     dlg = CommitDialog(wt)
   File "/usr/lib/python2.6/dist-packages/bzrlib/plugins/gtk/commit.py", line 132, in __init__
     self._saved_commit_messages_manager = SavedCommitMessagesManager(self._wt, self._wt.branch)
   File "/usr/lib/python2.6/dist-packages/bzrlib/plugins/gtk/commit.py", line 815, in __init__
     config = branch.get_config()._get_branch_data_config()
 AttributeError: 'BranchConfig' object has no attribute '_get_branch_data_config'

IMO, using private methods in GUI is not the best idea?

affects: bzr → bzr-gtk
Jelmer Vernooij (jelmer)
Changed in bzr-gtk:
status: New → Fix Released
assignee: nobody → Jelmer Vernooij (jelmer)
importance: Undecided → Medium
importance: Medium → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.