location of merge proposal status in email is confusing

Bug #592771 reported by Brian Murray
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Unassigned

Bug Description

I received an e-mail from a merge proposal with the following body:

Review: Approve code
On Thu, Jun 10, 2010 at 10:10 PM, Brian Murray <email address hidden> wrote:
> On Thu, Jun 10, 2010 at 01:06:29PM -0000, Michael Nelson wrote:
>> Review: Needs Information code
>> Hi Brian,
>>
>> Nice change and tests. I'm a bit confused by the bug though. From what
>> I've understood, suppress_notify should be False by default so that
>> when Joe subscribes Elsie else via the API and *doesn't* use the
>> suppress_notify arg, Elsie will receive an email letting her know that
>> she's been subscribed.
>>
>> So, 3 points:
>> 1) How does this prevent abuse? If I want to abuse the feature I just
>> use the suppress_notify=True. Shouldn't we instead be changing the
>> default to False as you have and leaving it unexposed so that people
>> can't abuse this via the API? I couldn't see any discussion about this
>> on the bug.
>
> I'm under the impression that using @call_with means that it will not be
> usable as an operation parameter of subscribe via the API interface and
> subsequently notifications will always be sent when someone is
> subscribed via the API.

And you're right, of course - sorry I misread @call_with... I was thinking of @operation_parameters.

----

Because the reviewer's reply was contextual I completely read over the "Review: Approve code" bit and started reading their comments only. I think this might be avoided by at least inserting a line of white space between the status and the "On Thu" bit. Even better would be to have an X-Launchpad-Merge-Proposal status or something in the e-mail headers.

Revision history for this message
Tim Penhey (thumper) wrote :

Yes I agree with this. We could easily add a header, and also an extra blank line.

Changed in launchpad-code:
importance: Undecided → Medium
status: New → Triaged
tags: added: code-review confusing-ui email
Curtis Hovey (sinzui)
Changed in launchpad:
importance: Medium → Low
William Grant (wgrant)
Changed in launchpad:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.