Odoo Addons (MOVED TO GITHUB)

Error message in purchase not correctly closed inside _(...)

Bug #606960 reported by Jordi Esteve (www.zikzakmedia.com) on 2010-07-18

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Odoo Addons (MOVED TO GITHUB)	Fix Released	Undecided	Anup(SerpentCS)	Odoo Addons (MOVED TO GITHUB) 5.0.13

purchase module, purchase.py file, line 220 (5.0 version):

raise osv.except_osv(_('Invalid action !'), _('Cannot delete Purchase Order(s) which are in %s State!' % s['state']))

should be

raise osv.except_osv(_('Invalid action !'), _('Cannot delete Purchase Order(s) which are in %s State!') % s['state'])

The variables should not been included inside _(...)

Revision history for this message

Anup(SerpentCS) (anup-serpent) wrote on 2010-07-19:

Hello Jordi Esteve,

I have checked the issue and i have found a solution for that here i am attaching a patch. Would you please check it and let us know your views.

Thanks.

Changed in openobject-addons:
status:	New → In Progress
assignee:	nobody → Anup (Open ERP) (ach-openerp)

Revision history for this message

Jordi Esteve (www.zikzakmedia.com) (jesteve-zikzakmedia) wrote on 2010-07-19:

The patch works fine, it allows to translate the error message and the purchase order state correctly. Thanks.

I think a similar patch should be applied in other modules where the error message and the state name of the object appear together.

Revision history for this message

Anup(SerpentCS) (anup-serpent) wrote on 2010-07-19:

Hello Jordi Esteve,

Thanks for your comments. We'll surely look at the other changes where we have such situations.

Thanks.

Revision history for this message

Anup(SerpentCS) (anup-serpent) wrote on 2010-08-30:

Hello Jordi Esteve,

It has been fixed by revision 2828 <email address hidden>

Thanks.

Changed in openobject-addons:
milestone:	none → 5.0.13
status:	In Progress → Fix Released

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Bug watches keep track of this bug in other bug trackers.