Evergreen

receipt template macros should have access to address, phone numbers

Bug #608308 reported by Galen Charlton
42
This bug affects 9 people
Affects Status Importance Assigned to Milestone
Evergreen
Confirmed
Wishlist
Unassigned
Evergreen 3.next

Bug Description

It would be handy if various receipt templates had macros for additional fields from the workstation org unit (or target library in the case of transit slips):

* library address (for each type, possibly with a set of convenience macros to default to the library mailing address if that's the only type set up)
* library phone number
* library email address

Galen Charlton (gmc)
Changed in evergreen:
importance: Undecided → Wishlist
James Fournie (jfournie)
Changed in evergreen:
status: New → Triaged
Revision history for this message
Jeff Godin (jgodin) wrote :

The working branch user/jeff/receipt_library_phone_and_email contains two of the three wishlist items in this bug.

Also, since the library phone/email address fields are more likely than the library name to be null/undefined, the branch contains an adjustment to escape_html that more gracefully handles such values.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeff/receipt_library_phone_and_email

Revision history for this message
Jason Stephenson (jstephenson) wrote :

Jeff,

Is your code on this branch ready to be considered? If so, you should tag the bug with a pullrequest tag.

Jason

Revision history for this message
Pasi Kallinen (paxed) wrote :

The branch is missing signoffs, and the escape_html() fix commit is moot, as that seems to be already fixed in master.

Jeff Godin (jgodin)
Changed in evergreen:
assignee: nobody → Jeff Godin (jgodin)
status: Triaged → In Progress
Revision history for this message
Jeff Godin (jgodin) wrote :

There has been renewed interest in this functionality, so I'm dusting off this bug and its working branch.

I'll see about adding the support for addresses as well as the new lib.info_url org unit setting.

Jeff Godin (jgodin)
Changed in evergreen:
milestone: none → 2.6.0-beta1
Dan Wells (dbw2)
Changed in evergreen:
milestone: 2.6.0-beta1 → 2.6.0-rc1
milestone: 2.6.0-rc1 → 2.next
Elaine Hardy (ehardy)
tags: added: printing receipt
Revision history for this message
Terran McCanna (tmccanna) wrote :

In web client 3.2.3 - library's email address and phone number are now available to print templates - {{current_location.email}} and {{current_location.phone}}.

Library address ID is available with {{current_location.mailing_address}} but I believe it needs to be fleshed a little further to actually get the address.

Terran McCanna (tmccanna)
Changed in evergreen:
status: In Progress → Confirmed
Revision history for this message
Terran McCanna (tmccanna) wrote :

Noting that library address still needs to be fleshed further in order to resolve this ticket.

Changed in evergreen:
assignee: Jeff Godin (jgodin) → Terran McCanna (tmccanna)
Terran McCanna (tmccanna)
Changed in evergreen:
assignee: Terran McCanna (tmccanna) → nobody
Terran McCanna (tmccanna)
Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
Terran McCanna (tmccanna)
Changed in evergreen:
assignee: Terran McCanna (tmccanna) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.