A running AnalyserQueue blocks GUI exit

Bug #609927 reported by William Good
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
William Good
1.8
Won't Fix
Low
William Good
1.9
Fix Released
Low
William Good

Bug Description

If you load a song that hasn't yet been analyzed (or start the analyzer on it manually through the library) and then exit (File -> Exit, not the WM close button), the GUI just hangs there (with the File menu highlighted) until the analyzer finishes.

Not really an end-of-the-world thing, just a nicety. I guess the preferred solution is to show a modal saying something to the effect of "Please wait for a moment while I'm analyzing your song, or click this button to abort and quit immediately" but it would probably be just as user-friendly to just hide the GUI window while the analyzer finishes. Right now it just freezes, which isn't very pretty.

Related branches

RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
Sean M. Pappalardo (pegasus-renegadetech) wrote :

My vote is for the modal box. (This avoids the appearance of the Mixxx process hanging.)

RJ Skerry-Ryan (rryan)
Changed in mixxx:
assignee: nobody → Bill Good (bkgood)
William Good (bkgood)
Changed in mixxx:
status: Confirmed → In Progress
Revision history for this message
William Good (bkgood) wrote :

Fixed at lp:mixxx/1.9 r2639

I ended up just hiding the window, opening a dialog of some sort was turning into a total pain (can't create a dialog in a hung GUI...). Only solution would be to move destruction of MixxxApp to a different thread and that's a can of worms I'm not willing to open at the moment over a relatively rare/minor bug.

Changed in mixxx:
milestone: none → 1.9.0
status: In Progress → Fix Committed
milestone: 1.9.0 → none
Revision history for this message
William Good (bkgood) wrote :

Fixed in lp:mixxx/1.8 r2698

Revision history for this message
William Good (bkgood) wrote :

I'm marking this wontfix -- which is utterly stupid, because I committed the fix first to 1.8 before merging to 1.9, but that was also before I knew we weren't releasing anything more from 1.8 and I don't want this to sit as "fix committed" in the 1.8 series for perpetuity.

RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5463

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.