Trunk : Icon should be consistent for 'cancel' buttons!

Bug #610845 reported by GEM
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Low
Ravindra Mekhiya(OpenERP)

Bug Description

just a problem of icon :
see menu accounting>reporting>generic reporting>partner accounts>partner balance
see picture

Related branches

Revision history for this message
GEM (nimp3) wrote :
Revision history for this message
Navrang Oza (noz-tiny) wrote :

Hello,

We have very good view for the same.
You can check attachment.

Which browser you are using ?

Thanks.

Revision history for this message
GEM (nimp3) wrote :

firefox 3.6.8 on windows, the icon cancel is not the same as other cancel I had in other menus, see attachment of aged partner balance icon

Revision history for this message
GEM (nimp3) wrote :

i use the for the moment the branch lp:openerp-client-web, and not dev.

Revision history for this message
Navrang Oza (noz-tiny) wrote :

Hello,

For button icon, you can apply this patch.
May be this will solve your problem.

Thanks.

Revision history for this message
GEM (nimp3) wrote :

you write in the patch :

+.button_wid_string
is it div.button_wid_string or what you write ?

Revision history for this message
Vaibhav Darji (vaibhav-openerp) wrote :

Hello GEM,
 div.button_wid_string is replaced by .button_wid_string.
 so, it's right.

Thanks.

Revision history for this message
GEM (nimp3) wrote :

now I have the same order presentation, but the color (red) and form (cross) of icon are not the same :
see picture

Revision history for this message
Navrang Oza (noz-tiny) wrote :

Hello GEM,

You are asking for

>> +.button_wid_string
>> is it div.button_wid_string or what you write ?

Its very simple to understand.
Sorry, but do you have idea about CSS ?

Thanks.

Revision history for this message
GEM (nimp3) wrote :

yes (but I'm not css user/master), that's the reason why I found this strange to have 2 different icons.
I will build web client with your branch and give the result.
Bye

Revision history for this message
GEM (nimp3) wrote :

with the branch dev, the cross is well centered, but as i said form and color are not the same as all button cancel in all menus.
Why I don't know, but it's a detail.
that's all.

Revision history for this message
GEM (nimp3) wrote :

with the branch dev, the cross is well centered, but as i said form and color are not the same as all button cancel in all menus.
Why I don't know, but it's a detail.
that's all.
Bye

Revision history for this message
Navrang Oza (noz-tiny) wrote :

Hello GEM,

We are displaying same like GTK.
Here in both the screen you can see the different icons on Cancel button.

I have checked :
In screen1 gtk-stop icons is used and
In screen2 gtk-cancel is used.
So its coming from server side.

You can check in GTK also.

Thanks.

Revision history for this message
Navrang Oza (noz-tiny) wrote :
Changed in openobject-client-web:
status: New → Invalid
Revision history for this message
GEM (nimp3) wrote :

Hi Noz,
effectively your right, I should had verified too.

see this code

addons/account/wizard/account_partner_balance_report_view.xml line 36 :
<button special="cancel" string="Cancel" icon="terp-gtk-stop"/>

addons/account/wizard/account_aged_trial_balance_view.xml line 22 :
<button special="cancel" string="Cancel" icon="gtk-cancel"/>

I search in all addons, and terp-gtk-stop is used 27 times.
If you think this should be harmonized, change to the branch server.I attached the listing of result of the search for terp-gtk-stop.

Thanks.
Bye

affects: openobject-client-web → openobject-addons
Changed in openobject-addons:
status: Invalid → Confirmed
Changed in openobject-addons:
importance: Undecided → Low
milestone: none → 6.0
summary: - v6 accounting->...>partner balance bad icon
+ Trunk : Icon should be consistent for 'cancel' buttons!
Revision history for this message
Navrang Oza (noz-tiny) wrote :

Thanks for the listing.
Actually this changes should be implemented at addons side, so bug is transfered to addons.

Thanks.

Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

It has been improved by revision 4309 <email address hidden>.
Thanks.

Changed in openobject-addons:
assignee: nobody → RME(OpenERP) (rme-openerp)
status: Confirmed → Fix Released
Revision history for this message
GEM (nimp3) wrote :

Thanks.
Bye

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.