some errors in source

Bug #619621 reported by ...
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
gnomeradio (Ubuntu)
Invalid
Undecided
Unassigned

Bug Description

Binary package hint: gnomeradio

gui.c: In function ‘initial_frequency_scan’:
gui.c:174: warning: format not a string literal and no format arguments
gui.c: In function ‘display_help_cb’:
gui.c:787: warning: format not a string literal and no format arguments
gui.c: In function ‘show_message’:
gui.c:1212: warning: format not a string literal and no format arguments
gui.c:1214: warning: format not a string literal and no format arguments

173 dialog = gtk_message_dialog_new(GTK_WINDOW(app), DIALOG_FLAGS, GTK_MESSAGE_QUESTION,
174 GTK_BUTTONS_YES_NO, text);

should be

173 dialog = gtk_message_dialog_new(GTK_WINDOW(app), DIALOG_FLAGS, GTK_MESSAGE_QUESTION,
174 GTK_BUTTONS_YES_NO, "%s", text);

and

786 dialog = gtk_message_dialog_new(NULL, DIALOG_FLAGS, GTK_MESSAGE_ERROR, GTK_BUTTONS_OK,
787 error->message);

should be

786 dialog = gtk_message_dialog_new(NULL, DIALOG_FLAGS, GTK_MESSAGE_ERROR, GTK_BUTTONS_OK,
787 "%s", error->message);

and

1211 dialog = gtk_message_dialog_new(NULL, DIALOG_FLAGS, type, GTK_BUTTONS_CLOSE,
1212 text);
1213 if (details) {
1214 gtk_message_dialog_format_secondary_text(GTK_MESSAGE_DIALOG(dialog), details);

should be

1211 dialog = gtk_message_dialog_new(NULL, DIALOG_FLAGS, type, GTK_BUTTONS_CLOSE,
1212 "%s", text);
1213 if (details) {
1214 gtk_message_dialog_format_secondary_text(GTK_MESSAGE_DIALOG(dialog), "%s", details);

Tags: maverick
Revision history for this message
David Sugar (dyfet-deactivatedaccount) wrote :

Thank you for this report.

I have checked this, and indeed this is both correct and still an issue in current Maverick sync'd from sid.

This of course needs to be reorganized as something that can be a debian patch, and then passed upstream to debian as well.

I can do this and produce an appropriate patch/revised package for this.

Changed in gnomeradio (Ubuntu):
assignee: nobody → David Sugar (dyfet)
Changed in gnomeradio (Ubuntu):
status: New → In Progress
Philip Muškovac (yofel)
tags: added: maverick
Revision history for this message
... (bugs-launchpad-net-pravec) wrote :

and there is some strange thing i cannot locate.

after i compiled gnomeradio and starting it and pressing about-button then about box appears. everything is fine so far. but after pressing the close button in this about window. the whole application will be closed.

this will happen doesn't matter if i apply the suggested corrections of mine or not. i am able to use c/c++ but prefer avr mcu ... so i am not absolutely sure where to search for errors in this case.

Revision history for this message
... (bugs-launchpad-net-pravec) wrote :

sorry. ignore last message, was my fault.

reason is -g -O2 switch in makefile.

damn ...

Revision history for this message
David Sugar (dyfet-deactivatedaccount) wrote :

I think this should be reviewed with the next merge from sid for Natty...

Changed in gnomeradio (Ubuntu):
assignee: David Sugar (dyfet) → nobody
status: In Progress → Confirmed
Revision history for this message
Pojar Geo (geoubuntu) wrote :

I'm marking this bug invalid as it affects a version of Ubuntu that is no longer maintained.

Changed in gnomeradio (Ubuntu):
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.