Launchpad itself

+downloads does not sort releases made on the same day properly

Bug #620494 reported by Curtis Hovey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
j.c.sackett
Launchpad itself 10.09 "Hungry Hippo"

Bug Description

ProductRelease.datereleased (and milestone.dateexpected) just use dates; 00:00:00 is added as the time. Releases are sorted by datereleased, so when multiple releases are made in the same day, they are shown in reverse order. This also causes the Latest downloads portlet to show the wrong release on the project +index page.

We can add an additional sort on milestone.name, or use milestone_sort_key.

Related branches

lp:~jcsackett/launchpad/620494-downloads-sort
Aaron Bentley (community): Approve
Diff: 69 lines (+40/-1)
2 files modified
lib/lp/registry/model/product.py (+8/-1)
lib/lp/registry/tests/test_product.py (+32/-0)
j.c.sackett (jcsackett)
Changed in launchpad-registry:
assignee: nobody → j.c.sackett (jcsackett)
Revision history for this message
Curtis Hovey (sinzui) wrote :

https://launchpad.net/ubuntu-sso-client/+download was the case that illustrated this problem. 0.98 and 0.99 were released on the same day, but 0.98 was listed first (because of db id).

j.c.sackett (jcsackett)
Changed in launchpad-registry:
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r11435 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11435>.

tags: added: qa-needstesting
Changed in launchpad-registry:
status: In Progress → Fix Committed
j.c.sackett (jcsackett)
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in launchpad-registry:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.