rohc

coding sequence number in Extension 3

Bug #622736 reported by afathy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
rohc
Status tracked in Rohc-main
1.2.x
Fix Released
Medium
Didier Barvaux
rohc 1.2.3
1.3.x
Fix Released
Medium
Didier Barvaux
rohc 1.3.2
Rohc-main
Fix Released
Medium
Didier Barvaux
rohc 1.4.0

Bug Description

sequence number requires S flag to be set to 1 if the number of bits in the packet format being used is not enough, this number is not only 5 bits as mentioned in the source code in c_generic.c at code_EXT3_packet():

it is 6 bits in UOR2-RTP, UOR2-TS, UOR2-ID

and 4 bits in UO1-ID

and 5 bits in UDP profile packets UO1, UOR2

Revision history for this message
Didier Barvaux (didier-barvaux) wrote :

Confirmed on 1.2.2.

Revision history for this message
Didier Barvaux (didier-barvaux) wrote :

Confirmed on 1.3.1.

Revision history for this message
Didier Barvaux (didier-barvaux) wrote :

Confirmed on main branch.

Revision history for this message
Didier Barvaux (didier-barvaux) wrote :

Thank you Ahmed for reporting this bug. This is a good catch!

Revision history for this message
Didier Barvaux (didier-barvaux) wrote :

Fixed in trunk. See http://bazaar.launchpad.net/~didier-barvaux/rohc/main/revision/302

Set S flag to 1 if there are more than:
 - 6 bits of SN in UOR-2-RPT, UOR-2-TS and UOR-2-ID,
 - 4 bits in UO-1-ID,
 - 5 bits in UOR-2 (non-RTP profiles).

Revision history for this message
Didier Barvaux (didier-barvaux) wrote :

Fixed in branch 1.3.x. See http://bazaar.launchpad.net/~didier-barvaux/rohc/1.3.x/revision/176

Set S flag to 1 if there are more than:
 - 6 bits of SN in UOR-2-RPT, UOR-2-TS and UOR-2-ID,
 - 5 bits in UOR-2 (non-RTP profiles).

Extension 3 is not handled at all for UO-1-ID packet.

Revision history for this message
Didier Barvaux (didier-barvaux) wrote :

Fixed in branch 1.2.x. See http://bazaar.launchpad.net/~didier-barvaux/rohc/1.2.x/revision/147

Set S flag to 1 if there are more than:
 - 6 bits of SN in UOR-2-RPT, UOR-2-TS and UOR-2-ID,
 - 5 bits in UOR-2 (non-RTP profiles).

Extension 3 is not handled at all for UO-1-ID packet.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.