Odoo Addons (MOVED TO GITHUB)

Unnecessary truncation in CRM case history view

Bug #628719 reported by Daniel Watkins (credativ) on 2010-09-02

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Odoo Addons (MOVED TO GITHUB)	Fix Released	Undecided	Unassigned	Odoo Addons (MOVED TO GITHUB) 6.0

Bug Description

Regardless of the length of the text in an entry in a CRM lead's history, it will look like it has been truncated.

To reproduce:
  1) Set up an OpenERP database with the crm module installed.
  2) Create a lead or opportunity in the database (the demonstration data will do).
  3) Go to the Form view for the lead
  4) Select the History tab
  5) Click on 'Send New Email'
  6) Enter whatever details you want for all but 'Message'
  7) Enter a single character for 'Message' (e.g. a)
  8) Click on Send

An entry in the log will be entered which looks like:
<email> wrote on <date>:
a...

This apparent truncation is unnecessary and misleading. It also occurs on longer inputs, up to, I believe, 3 lines.

This behaviour has been observed in lp:openobject-addons/trunk r4806.

Tags:

Related branches

lp:openobject-addons

Daniel Watkins (credativ) (daniel-watkins-credativ) on 2010-09-02

tags:

added: crm

Revision history for this message

Jay Vora (Serpent Consulting Services) (jayvora) wrote on 2010-09-07:

Hello Daniel,

The displayed detail is just a summary.
The '...' have been used to demonstrate that there is a text(disregard to any number of characters).

Thanks.

Changed in openobject-addons:
milestone:	none → 6.0
status:	New → Invalid

Revision history for this message

Daniel Watkins (credativ) (daniel-watkins-credativ) wrote on 2010-09-07:

I believe it to be misleading. It implies that there is more text than is displayed, when there is not. The code, in fact, assumes that it is truncating to the first three lines, when this is not necessarily the case.

msg_txt += '\n\t'.join(message.description.split('\n')[:3]) + '...'

I'm not saying it should be a high priority, but it _is_ a bug, and I think there should be a record of it.

Changed in openobject-addons:
status:	Invalid → New

Revision history for this message

Nathan (nathan-bowden-kiwi) wrote on 2010-09-09:

+1 Daniel.

Changed in openobject-addons:
status:	New → Opinion

Revision history for this message

Rucha (Open ERP) (rpa-openerp) wrote on 2010-09-09:

Lead_History_With_Truncation.png.png Edit (85.5 KiB, image/png)

I agree with Daniel,
but we need to truncate the message to some specific lines so the whole communication history can be visible properly, and we can display messages less than 3 lines without "..."
I attach a screenshot (after improvements) that clearly displays messages with 1-3 lines and with more lines,