Launchpad itself

remove workaround for private Librarian files for launchpadlib clients

Bug #629804 reported by Abel Deuring
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Abel Deuring
Launchpad itself 11.01

Bug Description

It is at present not possible to access the content of restricted Librarian files via the webservice API. The branch lp:~adeuring/launchpad/bug-620458-private-bugattachments-api-access fixes this for machines in our data center in a quite hackish, ugly way.

As the publicrestricted-librarian is now live we can remove the workaround (and indeed all the disk spooling code).

To QA this, make sure an API client can access a restricted file on qastaging. I suggest filing a private bug and adding an attachment to it.

See original description

Related branches

lp:~lifeless/launchpad/librarian-filealiases
Robert Collins (community): Approve
Diff: 307 lines (+16/-118)
7 files modified
lib/canonical/launchpad/browser/librarian.py (+3/-4)
lib/canonical/launchpad/rest/bytestorage.py (+0/-28)
lib/canonical/launchpad/webapp/servers.py (+11/-14)
lib/canonical/launchpad/zcml/webservice.zcml (+0/-13)
lib/lp/bugs/interfaces/bugattachment.py (+2/-2)
lib/lp/bugs/stories/webservice/xx-bug.txt (+0/-40)
lib/lp/services/fields/__init__.py (+0/-17)
lp:~adeuring/launchpad/librarian-filealiases
Graham Binns (community): Approve (code)
Diff: 280 lines (+16/-109)
6 files modified
lib/canonical/launchpad/browser/librarian.py (+13/-14)
lib/canonical/launchpad/rest/bytestorage.py (+0/-28)
lib/canonical/launchpad/zcml/webservice.zcml (+0/-13)
lib/lp/bugs/interfaces/bugattachment.py (+2/-2)
lib/lp/bugs/stories/webservice/xx-bug.txt (+1/-41)
lib/lp/services/fields/__init__.py (+0/-11)
lp:~gary/launchpad/revert12041-2
Gary Poster (community): Approve
Diff: 0 lines
lp:~adeuring/launchpad/webservice-access-to-private-bug-attamchments
Leonard Richardson (community): Approve
Graham Binns (community): Approve (code)
Diff: 85 lines (+14/-33)
2 files modified
lib/lp/bugs/browser/tests/test_bugattachment_file_access.py (+12/-8)
lib/lp/testing/_webservice.py (+2/-25)
Robert Collins (lifeless)
Changed in launchpad-foundations:
status: New → Triaged
importance: Undecided → High
summary: - implement access to private Librarian files for launchpadlib clients
+ remove workaround for private Librarian files for launchpadlib clients
description: updated
Robert Collins (lifeless)
Changed in launchpad-foundations:
assignee: nobody → Robert Collins (lifeless)
status: Triaged → In Progress
Robert Collins (lifeless)
description: updated
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r12041 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12041>.

tags: added: qa-needstesting
Changed in launchpad-foundations:
status: In Progress → Fix Committed
Revision history for this message
Abel Deuring (adeuring) wrote :

a stupid commit: Launchpad simply shows the public download URL (which dies not contain the access token) of bug attachment to lplib clients

Changed in launchpad-foundations:
status: Fix Committed → In Progress
Abel Deuring (adeuring)
tags: added: qa-bad
removed: qa-needstesting
Robert Collins (lifeless)
Changed in launchpad-foundations:
assignee: Robert Collins (lifeless) → nobody
Revision history for this message
Deryck Hodge (deryck) wrote :

Marking qa-ok since r12041 has been reverted. Abel forgot to use the --rollback flag. Also, I'm sorry to say I'm still dumb about what to do to patch up the tagging when this happens. If we need a bad commit tag manually, or not?

tags: added: qa-ok
removed: qa-bad
Changed in launchpad:
status: In Progress → Triaged
Revision history for this message
Diogo Matsubara (matsubara) wrote :

Set to qa-bad again to block deployment until we sort out the confusion done by the revert. Due to the missing --rollback option the https://devpad.canonical.com/~lpqateam/qa_reports/deployment-stable.html is reporting the wrong revision to be deployed.

tags: added: qa-bad
removed: qa-ok
Revision history for this message
Abel Deuring (adeuring) wrote : Re: [Bug 629804] Re: remove workaround for private Librarian files for launchpadlib clients

On 16.12.2010 17:50, Diogo Matsubara wrote:
> Set to qa-bad again to block deployment until we sort out the confusion
> done by the revert. Due to the missing --rollback option the
> https://devpad.canonical.com/~lpqateam/qa_reports/deployment-stable.html
> is reporting the wrong revision to be deployed.
>
> ** Tags added: qa-bad
> ** Tags removed: qa-ok
>

Absolutely correct to label the branch qa-bad: Not only did I forget to
label the commit message with "rollback" -- it was rejected anyway
because PQM was in testfix mode... Submitting the rollback branch
(lp:~adeuring/launchpad/backout-librarian-filealias) now again. Sorry
for the delay.

Revision history for this message
Francis J. Lacoste (flacoste) wrote :

Actually, Gary already merged the rollback yesterday. I'll link the branch.

Revision history for this message
Francis J. Lacoste (flacoste) wrote :

Marked as qa-ok to unblock the qa-tagger report, but 12041 shouldn't be rolled out without 12080.

tags: added: bad-commit-12041 qa-ok
removed: qa-bad
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r12165 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12165>.

Changed in launchpad:
assignee: nobody → Abel Deuring (adeuring)
milestone: none → 11.01
tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: Triaged → Fix Committed
Abel Deuring (adeuring)
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.