python-mode.el

py-previous-statement fails

Bug #637955 reported by Andreas Roehler
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-mode.el
Fix Released
Undecided
Andreas Roehler
python-mode.el 6.0 "Myrkwid"

Bug Description

`py-goto-initial-line' stops inside triple-quoted-string

class OrderedDict1(dict):
    """
    This implementation of a dictionary keeps track of the order
    in which keys were inserted.
|__ """

Point in first column of last code-line above.

M-x py-previous-statement

doesn't reach class or beginning of buffer, but goes just one line
upward, further into the string.

AFAIS bug is in `py-goto-initial-line'.

Related branches

lp:~a-roehler/python-mode/py-goto-initial-line
Barry Warsaw: Needs Fixing (code)
Diff: 25 lines (+6/-2)
1 file modified
python-mode.el (+6/-2)
lp:python-mode
lp:~a-roehler/python-mode/myrkwid
python-mode.el developers: Pending requested
Diff: 5004 lines (+2516/-1849)
5 files modified
UnicodeEncodeError-lp:550661-test.py (+4/-0)
py-bug-numbered-tests.el (+738/-245)
python-mode-test.el (+202/-0)
python-mode-tests.sh (+88/-0)
python-mode.el (+1484/-1604)
Revision history for this message
Barry Warsaw (barry) wrote :

Please propose branch for merging to trunk when you're ready and I'll review it.

Andreas Roehler (a-roehler)
Changed in python-mode:
assignee: nobody → Andreas Roehler (a-roehler)
Andreas Roehler (a-roehler)
Changed in python-mode:
status: New → Confirmed
Revision history for this message
Barry Warsaw (barry) wrote :

Confirmed that this works now.

Changed in python-mode:
status: Confirmed → Fix Committed
Revision history for this message
Barry Warsaw (barry) wrote : Re: [Bug 637955] Re: py-previous-statement fails

On Jan 28, 2011, at 06:39 PM, Andreas Röhler wrote:

>Am 14.10.2010 13:13, schrieb Andreas Roehler:
>> ** Changed in: python-mode
>> Assignee: (unassigned) => Andreas Roehler (a-roehler)
>>
>
>Hi Barry,
>
>AFAIS it's gone in the trunk now.
>
>Could you check it again, so it may be closed?

Works for me. Is it time for a 5.2.1 release?

-Barry

Revision history for this message
Andreas Roehler (a-roehler) wrote :

Am 28.01.2011 19:19, schrieb Barry Warsaw:
> On Jan 28, 2011, at 06:39 PM, Andreas Röhler wrote:
>
>> Am 14.10.2010 13:13, schrieb Andreas Roehler:
>>> ** Changed in: python-mode
>>> Assignee: (unassigned) => Andreas Roehler (a-roehler)
>>>
>>
>> Hi Barry,
>>
>> AFAIS it's gone in the trunk now.
>>
>> Could you check it again, so it may be closed?
>
> Works for me. Is it time for a 5.2.1 release?
>
> -Barry
>

Hi Barry,

just pushed onto paragraph-fill-warts, which should fix the tqs-bugs for
XEmacs.

Maybe merge that before a release?
Probably some further checking will be good.

Andreas

Andreas Roehler (a-roehler)
Changed in python-mode:
milestone: none → 6.0
Andreas Roehler (a-roehler)
Changed in python-mode:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.