remove basic auth (and passwords) - neither are used outside of the test suite
Bug #644105 reported by
Robert Collins
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
William Grant | ||
Bug Description
Basic auth is still in the code base, and still AFAICT live on prod; we'll need to fixup some test stuff to make it work, but deleting it would make the LP code around the start of a request considerably leaner and cleaner.
Related branches
lp:~wgrant/launchpad/purge-more-password
- William Grant: Approve (code)
-
Diff: 153 lines (+0/-68)3 files modifiedlib/lp/app/validators/validation.py (+0/-33)
lib/lp/services/fields/__init__.py (+0/-20)
lib/lp/services/verification/interfaces/authtoken.py (+0/-15)
lp:~wgrant/launchpad/drop-accountish-bits
- Stuart Bishop (community): Approve (db)
- Robert Collins: Pending (db) requested
- Launchpad code reviewers: Pending requested
-
Diff: 836 lines (+247/-380)6 files modifieddatabase/sampledata/current-dev.sql (+135/-196)
database/sampledata/current.sql (+102/-163)
database/schema/comments.sql (+0/-6)
database/schema/patch-2209-01-1.sql (+10/-0)
database/schema/security.cfg (+0/-13)
database/schema/security.py (+0/-2)
Revision history for this message
| Guilherme Salgado (salgado) wrote Re: [Bug 644105] [NEW] remove basic auth | #1 |
Revision history for this message
| Robert Collins (lifeless) wrote | #2 |
Revision history for this message
| Guilherme Salgado (salgado) wrote Re: remove basic auth | #3 |
| Changed in launchpad-foundations: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
| summary: |
- remove basic auth + remove basic auth (and passwords) - neither are used outside of the test + suite |
Revision history for this message
| William Grant (wgrant) wrote | #5 |
| Changed in launchpad: | |
| assignee: | nobody → William Grant (wgrant) |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #6 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #7 |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
| tags: | added: disclosure sharing |
To post a comment you must log in.
I think the trickiest thing to fix will be the windmill tests, which
can't login using openid because windmill can't cope with crossing
multiple hostnames.
subscribe yes