[Upstream] Calc loses row height value when modifying a cell

Created attachment 43637
row-height.xls

Downstream bug may be found at:
https://bugs.launchpad.net/ubuntu/+source/openoffice.org/+bug/646157

In Ubuntu 11.04, libreoffice-calc perform at the Terminal:

cd ~/Desktop && wget https://bugs.launchpad.net/ubuntu/+source/openoffice.org/+bug/646157/+attachment/1655284/+files/row-height.xls && localc -nologo row-height.xls

Row 8 height is 0.17". Highlighted row 8, changed background color to black, the height changed to 0.40". Pressed Ctrl+Z to undo, the color changed back, but the row height did not.

lsb_release -rd
Description: Ubuntu natty (development branch)
Release: 11.04

apt-cache policy libreoffice-calc
libreoffice-calc:
  Installed: 1:3.3.0-1ubuntu1
  Candidate: 1:3.3.0-1ubuntu1
  Version table:
 *** 1:3.3.0-1ubuntu1 0
        500 http://us.archive.ubuntu.com/ubuntu/ natty/main i386 Packages
        100 /var/lib/dpkg/status

The effect is [Reproducible] with "LibreOffice 3.3.1 RC2 – WIN7 Home Premium (64bit) German UI [OOO330m19 (build 8 / tag 3.3.1.2)]", but only in the sample document. I did lots of tests with own documents without success, I was not able to reproduce the problem.
Problem is not visible with OOo 3.4-dev

Created attachment 43637
row-height.xls

Downstream bug may be found at:
https://bugs.launchpad.net/ubuntu/+source/openoffice.org/+bug/646157

In Ubuntu 11.04, libreoffice-calc perform at the Terminal:

cd ~/Desktop && wget https://bugs.launchpad.net/ubuntu/+source/openoffice.org/+bug/646157/+attachment/1655284/+files/row-height.xls && localc -nologo row-height.xls

Row 8 height is 0.17". Highlighted row 8, changed background color to black, the height changed to 0.40". Pressed Ctrl+Z to undo, the color changed back, but the row height did not.

lsb_release -rd
Description: Ubuntu natty (development branch)
Release: 11.04

apt-cache policy libreoffice-calc
libreoffice-calc:
  Installed: 1:3.3.0-1ubuntu1
  Candidate: 1:3.3.0-1ubuntu1
  Version table:
 *** 1:3.3.0-1ubuntu1 0
        500 http://us.archive.ubuntu.com/ubuntu/ natty/main i386 Packages
        100 /var/lib/dpkg/status

The effect is [Reproducible] with "LibreOffice 3.3.1 RC2 – WIN7 Home Premium (64bit) German UI [OOO330m19 (build 8 / tag 3.3.1.2)]", but only in the sample document. I did lots of tests with own documents without success, I was not able to reproduce the problem.
Problem is not visible with OOo 3.4-dev

Reproducible in Ubuntu 10.10 LibreOffice 3.3.1

lsb_release -rd
Description: Ubuntu 10.10
Release: 10.10

apt-cache policy libreoffice-calc
libreoffice-calc:
  Installed: 1:3.3.1-1ubuntu3~maverick1
  Candidate: 1:3.3.1-1ubuntu3~maverick1
  Version table:
 *** 1:3.3.1-1ubuntu3~maverick1 0
        500 http://ppa.launchpad.net/libreoffice/ppa/ubuntu/ maverick/main i386 Packages
        100 /var/lib/dpkg/status

Reproducible in Ubuntu 10.10 LibreOffice 3.3.1

lsb_release -rd
Description: Ubuntu 10.10
Release: 10.10

apt-cache policy libreoffice-calc
libreoffice-calc:
  Installed: 1:3.3.1-1ubuntu3~maverick1
  Candidate: 1:3.3.1-1ubuntu3~maverick1
  Version table:
 *** 1:3.3.1-1ubuntu3~maverick1 0
        500 http://ppa.launchpad.net/libreoffice/ppa/ubuntu/ maverick/main i386 Packages
        100 /var/lib/dpkg/status

[This is an automated message.]
This bug was filed before the changes to Bugzilla on 2011-10-16. Thus it
started right out as NEW without ever being explicitly confirmed. The bug is
changed to state NEEDINFO for this reason. To move this bug from NEEDINFO back
to NEW please check if the bug still persists with the 3.5.0 beta1 or beta2 prereleases.
Details on how to test the 3.5.0 beta1 can be found at:
http://wiki.documentfoundation.org/QA/BugHunting_Session_3.5.0.-1

more detail on this bulk operation: http://nabble.documentfoundation.org/RFC-Operation-Spamzilla-tp3607474p3607474.html

[This is an automated message.]
This bug was filed before the changes to Bugzilla on 2011-10-16. Thus it
started right out as NEW without ever being explicitly confirmed. The bug is
changed to state NEEDINFO for this reason. To move this bug from NEEDINFO back
to NEW please check if the bug still persists with the 3.5.0 beta1 or beta2 prereleases.
Details on how to test the 3.5.0 beta1 can be found at:
http://wiki.documentfoundation.org/QA/BugHunting_Session_3.5.0.-1

more detail on this bulk operation: http://nabble.documentfoundation.org/RFC-Operation-Spamzilla-tp3607474p3607474.html

> To move this bug from NEEDINFO back to NEW please check
> if the bug still persists with the 3.5.0 beta1 or beta2
> prereleases.

Reproduced with

LOdev 3.5.0beta2
Build ID: 4ca392c-760cc4d-f39cf3d-1b2857e-60db978

No magic self-fixing for this bug so far.

> To move this bug from NEEDINFO back to NEW please check
> if the bug still persists with the 3.5.0 beta1 or beta2
> prereleases.

Reproduced with

LOdev 3.5.0beta2
Build ID: 4ca392c-760cc4d-f39cf3d-1b2857e-60db978

No magic self-fixing for this bug so far.

Reproducible in:
LOdev 3.5.0beta2
Build ID: 8589e48-760cc4d-f39cf3d-1b2857e-60db978
Microsoft Windows Vista Business 6.0.6002 Service Pack 2 Build 6002

This does not occur using Microsoft Office Excel 2003 (11.5612.6505).

Reproducible in:
LOdev 3.5.0beta2
Build ID: 8589e48-760cc4d-f39cf3d-1b2857e-60db978
Microsoft Windows Vista Business 6.0.6002 Service Pack 2 Build 6002

This does not occur using Microsoft Office Excel 2003 (11.5612.6505).

This one might be related to "Bug 34717 - FILEOPEN FORMATTING: automatic row height is too small in particular .xls".

Already a problem with 3.3.0, but oK with AOOo.

Bug description here is wrong, the problem is not that the row height changes when editing a cell, but that the row height is too small when you open the document with LibO. The edit heals the problem.

I am nearby 100% sure that this one is concerning the same problem as "Bug 34717 - FILEOPEN FORMATTING: automatic row height is too small in particular .xls".

So I mark this one as a DUP, because in Bug 34717 we have most advanced examinations.

@reporter:
Please feel free to reopen this Bug if you find evidence that we have an independent issue here.

*** This bug has been marked as a duplicate of bug 34717 ***

This one might be related to "Bug 34717 - FILEOPEN FORMATTING: automatic row height is too small in particular .xls".

Already a problem with 3.3.0, but oK with AOOo.

Bug description here is wrong, the problem is not that the row height changes when editing a cell, but that the row height is too small when you open the document with LibO. The edit heals the problem.

I am nearby 100% sure that this one is concerning the same problem as "Bug 34717 - FILEOPEN FORMATTING: automatic row height is too small in particular .xls".

So I mark this one as a DUP, because in Bug 34717 we have most advanced examinations.

@reporter:
Please feel free to reopen this Bug if you find evidence that we have an independent issue here.

*** This bug has been marked as a duplicate of bug 34717 ***

Rainer Bielefeld,thank you for working on this report. Regarding your comments https://bugs.freedesktop.org/show_bug.cgi?id=34552#c6 :

>"This one might be related to "Bug 34717 - FILEOPEN FORMATTING: automatic row
height is too small in particular .xls"."

Agreed in that this is similar in the problem to bugs 34717, 50044, and 39486 due to .xls correlation, and seemingly, the code requiring a fix. However, this bug is about how when one modifies the document while already open and then undoes, the row height is no longer honored. The other bugs are all about the problem already occurring when one only opens the file.

>"Already a problem with 3.3.0, but oK with AOOo."

So, this problem exists as early as LO 3.3.0, but does not in current AOOo? If so, which AOOo version specifically?

>"Bug description here is wrong, the problem is not that the row height changes
when editing a cell, but that the row height is too small when you open the
document with LibO. The edit heals the problem.

I am nearby 100% sure that this one is concerning the same problem as "Bug
34717 - FILEOPEN FORMATTING: automatic row height is too small in particular
.xls".

So I mark this one as a DUP, because in Bug 34717 we have most advanced
examinations.

@reporter:
Please feel free to reopen this Bug if you find evidence that we have an
independent issue here.

*** This bug has been marked as a duplicate of bug 34717 ***"

Regarding this bug, the Bug Description is not wrong. It describes verbatim the bug phenomenon the downstream bug reporter wants a developer to address. This may end up being addressed by commit(s) issued for the 3 other reports previously mentioned, or vice versa. But, until this is so, let us please leave this unduped.

Thank you for your understanding.

Rainer Bielefeld,thank you for working on this report. Regarding your comments https://bugs.freedesktop.org/show_bug.cgi?id=34552#c6 :

>"This one might be related to "Bug 34717 - FILEOPEN FORMATTING: automatic row
height is too small in particular .xls"."

Agreed in that this is similar in the problem to bugs 34717, 50044, and 39486 due to .xls correlation, and seemingly, the code requiring a fix. However, this bug is about how when one modifies the document while already open and then undoes, the row height is no longer honored. The other bugs are all about the problem already occurring when one only opens the file.

>"Already a problem with 3.3.0, but oK with AOOo."

So, this problem exists as early as LO 3.3.0, but does not in current AOOo? If so, which AOOo version specifically?

>"Bug description here is wrong, the problem is not that the row height changes
when editing a cell, but that the row height is too small when you open the
document with LibO. The edit heals the problem.

I am nearby 100% sure that this one is concerning the same problem as "Bug
34717 - FILEOPEN FORMATTING: automatic row height is too small in particular
.xls".

So I mark this one as a DUP, because in Bug 34717 we have most advanced
examinations.

@reporter:
Please feel free to reopen this Bug if you find evidence that we have an
independent issue here.

*** This bug has been marked as a duplicate of bug 34717 ***"

Regarding this bug, the Bug Description is not wrong. It describes verbatim the bug phenomenon the downstream bug reporter wants a developer to address. This may end up being addressed by commit(s) issued for the 3 other reports previously mentioned, or vice versa. But, until this is so, let us please leave this unduped.

Thank you for your understanding.

I tried to reproduce this on:
- Debian x86-64 with 3.6 sources updated today.
- Win7 64, with 3.6.4.3
In both cases, I haven't reproduced the behaviour described in comment1.
Of course, I had to undo twice, since there were 2 actions to undo.
Perhaps I missed something but could someone give a try with 3.6.4.3?

I tried to reproduce this on:
- Debian x86-64 with 3.6 sources updated today.
- Win7 64, with 3.6.4.3
In both cases, I haven't reproduced the behaviour described in comment1.
Of course, I had to undo twice, since there were 2 actions to undo.
Perhaps I missed something but could someone give a try with 3.6.4.3?

Problem reproducible in:
Microsoft Windows Vista Business x86
6.0.6002 Service Pack 2 Build 6002
Version 4.0.0.0.beta2 (Build ID: 4104d660979c57e1160b5135634f732918460a0)

However, the row height changes to 0.21", instead of that reported in the Description (0.40").

Problem reproducible in:
Microsoft Windows Vista Business x86
6.0.6002 Service Pack 2 Build 6002
Version 4.0.0.0.beta2 (Build ID: 4104d660979c57e1160b5135634f732918460a0)

However, the row height changes to 0.21", instead of that reported in the Description (0.40").

*** Bug 65837 has been marked as a duplicate of this bug. ***

*** Bug 65837 has been marked as a duplicate of this bug. ***

Valuable information by Nick on Bug 65837:
https://bugs.freedesktop.org/show_bug.cgi?id=65837#c11

Valuable information by Nick on Bug 65837:
https://bugs.freedesktop.org/show_bug.cgi?id=65837#c11

** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

   *Test to see if the bug is still present on a currently supported version of LibreOffice (4.4.1 or later)
   https://www.libreoffice.org/download/

   *If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior

   *If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System

Please DO NOT

   *Update the version field
   *Reply via email (please reply directly on the bug tracker)
   *Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case)

If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:

1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3)

http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to "inherited from OOo";
4b. If the bug was not present in 3.3 - add "regression" to keyword

Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa

Thank you for your help!

-- The LibreOffice QA Team This NEW Message was generated on: 2015-04-01

This bug is indicated as a duplicate of #65837 reported by me. That bug is closed due to the duplication so I write here.

I checked my bug in _my_ latest LO which is:

Verzió: 4.3.1.2
Build az.: 958349dc3b25111dbca392fbc281a05559ef6848

Unfortunately I have no time at the moment to upgrade but I will test it in a newer version LO next week. Meanwhile I wanted to give some feedback. See you next week.

I managed to check it on the following version:

Version: 4.4.1.2
Build ID: 45e2de17089c24a1fa810c8f975a7171ba4cd432
Locale: en_AU

The symptom is still the same, the line height is growing unexpectedly. So yes, this is an existing bug.

I checked it on the newest LO version:

Version: 4.4.2.2
Build ID: c4c7d32d0d49397cad38d62472b0bc8acff48dd6
Locale: en_AU

The symptom is the same as I wrote in my original ticket (bug #65837). So yes, this is still an existing bug.

** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present on a currently supported version of LibreOffice (5.0.5 or 5.1.2 https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior

If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System

Please DO NOT

- Update the version field
- Reply via email (please reply directly on the bug tracker)
- Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case)

If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:

1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3)

http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug

3. Leave a comment with your results.

4a. If the bug was present with 3.3 - set version to "inherited from OOo";
4b. If the bug was not present in 3.3 - add "regression" to keyword

Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa

Thank you for your help!

-- The LibreOffice QA Team This NEW Message was generated on: 2016-04-16

I can confirm that the bug is present in the newest version:

Version: 5.1.2.2
Build ID: d3bf12ecb743fc0d20e0be0c58ca359301eb705f
CPU Threads: 8; OS Version: Linux 4.2; UI Render: default;
Locale: en-AU (en_AU.UTF-8)

Compared to my original bug report, a couple of things have been changed.
- 64 bit LO vs 32 bit
- I use Linux instead of Windows
- English OS vs Hungarian OS
- English LO vs Hungarian

So, it seems to be a pretty general bug. And, a pretty old one, it has been present at least since 2013-06-16 when I reported the original bug (https://bugs.documentfoundation.org/show_bug.cgi?id=65837).

On pc Debian x86-64 with master sources updated today, I could reproduce tdf#65837 (which is very quick to try)

Reverting https://cgit.freedesktop.org/libreoffice/core/commit/?id=1363fe2fa6849aa1ac678ea444c58a82d417eb47 allows to call AdjustRowHeight functions at the Excel import and tdf#65837 was ok (I must admit I haven't retested tdf#34552 before or after reverting this commit)

Here are the lines:
+#if 0
+ // Excel documents look much better without this call; better in the
+ // sense that the row heights are identical to the original heights in
+ // Excel.
         if (pD->IsAdjustHeightEnabled())
             AdjustRowHeight();
-
+#endif
(see http://opengrok.libreoffice.org/xref/core/sc/source/filter/excel/read.cxx#1298)

Eike/Katarina/Markus: any thought?
1) Should we let this as it is for perf (and so wontfix) ?
2) Should we let this block (or remove it since it's "#if 0") and call AdjustRowHeight at a specific location in order to not decrease too much perf?
3) Should we remove the if/endif (+associated comment) and let the 2 instructions? (because we know that perf should be ok now)
4) other?

(since Kohei removed himself from https://wiki.documentfoundation.org/FindTheExpert, I didn't want to annoy him with this).

I think leaving it as it is, this is the worst possible solution. Just imagine what happens to the user.

- they are working on a large workbook
- forgets saving because they are concentrating on the formulas, numbers, formatting, etc.
- changes the colour of the row
- oops, there is a bug, it makes the line height wrong. Never mind, let's undo it
- the colour changes back but the row height does not. Oops, this is another LO bug. Damned.
- Bloody LO, let's forget it once and forever.

To avoid this annoying situation, I think this bug should be fixed.

*** Bug 115324 has been marked as a duplicate of this bug. ***

** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not
appropriate in this case)

If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword

Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

I can confirm that the bug is still present in a quite recent (but not the newest) LO:

Version: 6.1.0.3
Build ID: efb621ed25068d70781dc026f7e9c5187a4decd1

Dear Christopher M. Penalver,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not
appropriate in this case)

If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword

Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

I tried and can confirm the bug is still present with the below version:

Version: 7.0.4.2
Build ID: dcf040e67528d9187c66b2379df5ea4407429775
CPU threads: 12; OS: Mac OS X 10.15.7; UI render: default; VCL: osx
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Here is what I did:

- clicked the row label of row #8
- clicked the background color icon on the toolbar and changed it black
- pressed Command-Z (MacOS equivalent of Ctrl-Z on Windows)

As opposed to the original bug report, the height hasn't been changed when I changed the color to black. But changed it when I used undo.

So, the bug is still there, just in a different shape.

This is a very weird bug. I still can reproduce the bug with the current master build of LO 7.4 and using the provided XLS file.

However, I was not able to create another file from scratch where this bug happens.

There's something special about the sample file that I could not figure out.