Recipe Manager

Don't search for words smaller than 3 letters

Bug #659234 reported by Jeff Fortin Tam on 2010-10-12

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Recipe Manager	Fix Committed	Low	Jeff Fortin Tam	Recipe Manager 0.4

Bug Description

I'm not sure how computationally expensive searching/filtering is with large amounts of recipes, but it probably doesn't make sense to start searching until the user has typed at least 3 characters (there are no significant 2-letter words...).

I'm wondering if limiting searches to strings of >=3 characters would boost search/filtering performance, because there would be less matches initially, so less updates to the listview widget, etc.

Tags:

Related branches

lp:recipe-manager

Revision history for this message

Jeff Fortin Tam (kiddo) wrote on 2011-04-12:

659234.patch Edit (515 bytes, text/plain)

A possible patch is attached.
The problem is that it causes a traceback when exiting the app:

Exception in thread Thread-1 (most likely raised during interpreter shutdown):
Traceback (most recent call last):
  File "/usr/lib/python2.6/threading.py", line 532, in __bootstrap_inner
  File "/home/jeff/dev/recipe-manager/main/librecipemanager/network.py", line 536, in run
  File "/usr/lib/python2.6/SocketServer.py", line 229, in serve_forever
  File "/usr/lib/python2.6/threading.py", line 380, in set
  File "/usr/lib/python2.6/threading.py", line 291, in notifyAll
<type 'exceptions.TypeError'>: 'NoneType' object is not callable