useless list comprehension and browse in split_moves
Bug #666781 reported by
Numérigraphe
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Odoo Addons (MOVED TO GITHUB) |
Fix Released
|
Low
|
OpenERP R&D Addons Team 2 | ||
Bug Description
Nothing important, but stock/stock_
move_ids = [m.id for m in [line for line in pick.move_lines]]
for move in move_obj.browse(cr, uid, move_ids, context=context):
I think [line for line in X] just makes a copy of X. Then we do it just to get ids and browse again.
So I suppose it should just read:
for move in move_lines:
Lionel
Related branches
lp:~openerp-dev/openobject-addons/rpa-dev-addons2
- OpenERP Core Team: Pending requested
-
Diff: 12 lines (+1/-1)1 file modifiedstock/stock_view.xml (+1/-1)
| summary: |
- useless list comprehension + useless list comprehension and browse in split_moves |
| description: | updated |
Revision history for this message
| Fabien (Open ERP) (fp-tinyerp) wrote | #1 |
| Changed in openobject-addons: | |
| status: | New → Confirmed |
| importance: | Undecided → Low |
| assignee: | nobody → OpenERP R&D Addons Team 2 (openerp-dev-addons2) |
| Changed in openobject-addons: | |
| status: | Confirmed → In Progress |
Revision history for this message
| Rucha (Open ERP) (rpa-openerp) wrote | #2 |
| Changed in openobject-addons: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
I agree, this code should be reviewed.
Thanks,