get-orig-source target is failing to clean binary files from the source tarball

Bug #667819 reported by Chris Coulson
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mozilla Thunderbird
Invalid
Medium
thunderbird (Ubuntu)
Fix Released
Critical
Unassigned

Bug Description

Binary package hint: thunderbird

Micah noticed this yesterday. We see this at the end of REMOVED+nobinonly.txt in the tarball:

$ cd mozilla
$ sh /home/chr1s/src/thunderbird/thunderbird.maverick/debian/mozclient/remove.binonly.sh
sh: Can't open /home/chr1s/src/thunderbird/thunderbird.maverick/debian/mozclient/remove.binonly.sh

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

We should add a check for this failing and either completely fail to create the tarball, or at least fail the build

Changed in thunderbird (Ubuntu):
importance: Undecided → Critical
status: New → Triaged
assignee: nobody → Micah Gersten (micahg)
Revision history for this message
Benjamin Drung (bdrung) wrote :
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

It's provided by mozilla-devscripts. Micah is already working on this though, but the priority is to fix the current removal script to work properly

Revision history for this message
In , Evan Peck (colors) wrote :

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux ppc; rv:11.0) Gecko/20100101 Firefox/11.0
Build ID: 20120410132944

Steps to reproduce:

Compile from source / This is an upstream bug from Ubuntu in Launchpad.
Original bug: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/667819
Reporter: Chris Coulson

Actual results:

This:

$ cd mozilla
$ sh /home/chr1s/src/thunderbird/thunderbird.maverick/debian/mozclient/remove.binonly.sh
sh: Can't open /home/chr1s/src/thunderbird/thunderbird.maverick/debian/mozclient/remove.binonly.sh

is at the end of REMOVED+nobinonly.txt in the tarball.

Expected results:

The removal script should have worked properly.
Script: get-orig-source provided by mozilla-devscripts

Revision history for this message
Evan Peck (colors) wrote :

Forwarded upstream to Bugzilla.
https://bugzilla.mozilla.org/show_bug.cgi?id=761037
Micah, Are you actively working on this?
And why is this Triaged?

Changed in thunderbird:
importance: Unknown → Medium
status: Unknown → New
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Huh, why on earth did you forward a packaging bug upstream?

Revision history for this message
In , Chris Coulson (chrisccoulson) wrote :

Not sure why this got reported here

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

And this was fixed a long time ago anyway

Changed in thunderbird (Ubuntu):
status: Triaged → Fix Released
Micah Gersten (micahg)
Changed in thunderbird (Ubuntu):
assignee: Micah Gersten (micahg) → nobody
Revision history for this message
Evan Peck (colors) wrote :

Eh?... Uh
I had a mix-up-
Like me to remove it?
Oh - I am so confused-
Sorry!

Changed in thunderbird:
status: New → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.