Checkbox

in graphics-2d.txt graphics-2d and graphics-2d-output are the same test

Bug #671144 reported by Jeff Lane 
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox
Fix Released
Low
Brendan Donegan

Bug Description

both the graphics-2d and graphics-2d-output tests are identical. the second one is automated just to spit output into the logs. Thses should be replaced with a single test that does both. And really, does this even need to be seen by the user? Obviously X is running if they're running the checkbox UI and seeing the testcase... so this could be made simply fully automated instead.

Related branches

lp:~brendan-donegan/checkbox/bug671144_xorg_version
Daniel Manrique (community): Approve
Sylvain Pineau (community): Approve
Diff: 51 lines (+5/-10)
2 files modified
debian/changelog (+2/-0)
jobs/graphics.txt.in (+3/-10)
lp:~roadmr/ubuntu/precise/checkbox/0.13.1
Mathieu Trudel-Lapierre: Needs Fixing
Diff: 471232 lines (+252651/-169867)
158 files modified
bin/checkbox-cli (+1/-1)
bin/checkbox-gtk (+1/-1)
bin/checkbox-urwid (+1/-1)
checkbox/lib/config.py (+3/-1)
checkbox/lib/template_i18n.py (+2/-1)
checkbox/parsers/submission.py (+8/-4)
checkbox/user_interface.py (+1/-1)
checkbox_gtk/gtk_interface.py (+8/-3)
data/whitelists/default.whitelist (+47/-21)
debian/changelog (+89/-1)
debian/checkbox-cli.postinst (+1/-0)
debian/checkbox-gtk.postinst (+1/-0)
debian/checkbox-urwid.postinst (+1/-0)
debian/control (+14/-36)
debian/hwtest-cli.postinst (+0/-6)
debian/hwtest-gtk.postinst (+0/-6)
debian/hwtest.postinst (+0/-6)
debian/hwtest.postrm (+0/-26)
debian/po/de.po (+3/-4)
debian/po/en_AU.po (+3/-4)
debian/po/en_GB.po (+4/-5)
debian/po/es.po (+5/-5)
debian/po/fr.po (+3/-4)
debian/po/he.po (+3/-4)
debian/po/hu.po (+3/-4)
debian/po/it.po (+3/-4)
debian/po/ja.po (+6/-10)
debian/po/nl.po (+3/-4)
debian/po/pl.po (+3/-4)
debian/po/pt_BR.po (+3/-4)
debian/po/ro.po (+3/-4)
debian/po/ru.po (+3/-4)
debian/po/zh_TW.po (+4/-7)
debian/rules (+3/-7)
install/config (+4/-5)
install/postinst (+17/-21)
jobs/audio.txt.in (+9/-12)
jobs/bluetooth.txt.in (+6/-14)
jobs/camera.txt.in (+1/-17)
jobs/firewire.txt.in (+32/-7)
jobs/graphics.txt.in (+18/-26)
jobs/keys.txt.in (+5/-9)
jobs/local.txt.in (+1/-1)
jobs/mediacard.txt.in (+318/-158)
jobs/memory.txt.in (+5/-10)
jobs/miscellanea.txt.in (+4/-5)
jobs/monitor.txt.in (+6/-0)
jobs/networking.txt.in (+11/-2)
jobs/optical.txt.in (+1/-2)
jobs/panel_clock_test.txt.in (+1/-1)
jobs/resource.txt.in (+9/-0)
jobs/suspend.txt.in (+69/-26)
jobs/usb.txt.in (+34/-17)
jobs/user_apps.txt.in (+2/-2)
jobs/wireless.txt.in (+62/-0)
plugins/apport_prompt.py (+4/-3)
plugins/backend_info.py (+10/-0)
plugins/intro_prompt.py (+7/-5)
plugins/jobs_prompt.py (+17/-5)
plugins/launchpad_report.py (+2/-1)
plugins/recover_prompt.py (+4/-2)
plugins/shell_test.py (+1/-1)
po/POTFILES.in (+2/-0)
po/ace.po (+2170/-1770)
po/af.po (+2164/-1770)
po/am.po (+2185/-1770)
po/ar.po (+2472/-2020)
po/ast.po (+3969/-2264)
po/be.po (+3927/-1931)
po/bg.po (+2819/-2045)
po/bn.po (+2942/-1956)
po/bo.po (+2245/-1778)
po/br.po (+2339/-1806)
po/bs.po (+3856/-2116)
po/ca.po (+3234/-2211)
po/ca@valencia.po (+2964/-1997)
po/checkbox.pot (+2147/-1763)
po/ckb.po (+2192/-1774)
po/cs.po (+3938/-2404)
po/cy.po (+2156/-1771)
po/da.po (+3571/-2266)
po/de.po (+5006/-2478)
po/dv.po (+2151/-1769)
po/el.po (+4319/-2105)
po/en_AU.po (+4874/-2289)
po/en_CA.po (+2560/-1864)
po/en_GB.po (+4974/-2336)
po/eo.po (+3109/-2165)
po/es.po (+4248/-2325)
po/et.po (+2236/-1791)
po/eu.po (+2323/-1796)
po/fa.po (+2151/-1769)
po/fi.po (+3351/-2252)
po/fr.po (+4114/-2246)
po/gd.po (+2125/-1739)
po/gl.po (+3802/-2056)
po/he.po (+2902/-2070)
po/hi.po (+2659/-1837)
po/hr.po (+2330/-1797)
po/hu.po (+3822/-2253)
po/hy.po (+2151/-1769)
po/id.po (+2295/-1892)
po/is.po (+2208/-1871)
po/it.po (+3970/-2446)
po/ja.po (+3387/-1984)
po/jbo.po (+2151/-1769)
po/ka.po (+2172/-1796)
po/kk.po (+2236/-1778)
po/km.po (+2151/-1769)
po/kn.po (+2176/-1770)
po/ko.po (+2712/-1858)
po/ku.po (+2167/-1770)
po/ky.po (+2151/-1769)
po/lt.po (+2333/-1776)
po/lv.po (+3318/-1899)
po/mk.po (+2250/-1891)
po/ml.po (+2160/-1769)
po/mr.po (+2163/-1769)
po/ms.po (+4978/-2213)
po/my.po (+2243/-1791)
po/nb.po (+2525/-1996)
po/nds.po (+2151/-1769)
po/ne.po (+2226/-1778)
po/nl.po (+4474/-2368)
po/nn.po (+2173/-1770)
po/oc.po (+2934/-1897)
po/pl.po (+3634/-2303)
po/pt.po (+3426/-2151)
po/pt_BR.po (+4988/-2313)
po/ro.po (+2809/-2049)
po/ru.po (+5108/-2399)
po/si.po (+2163/-1769)
po/sk.po (+2668/-2068)
po/sl.po (+3771/-2194)
po/sq.po (+3610/-1890)
po/sr.po (+3716/-2188)
po/sv.po (+3762/-2302)
po/ta.po (+2161/-1770)
po/te.po (+2160/-1769)
po/th.po (+2359/-1938)
po/tr.po (+3467/-2112)
po/ug.po (+3820/-2051)
po/uk.po (+2656/-1998)
po/ur.po (+2151/-1769)
po/vi.po (+2629/-1875)
po/zh_CN.po (+2970/-1990)
po/zh_HK.po (+2731/-1958)
po/zh_TW.po (+2718/-1901)
scripts/camera_test (+4/-30)
scripts/compiz-check (+0/-968)
scripts/connect_wireless (+1/-1)
scripts/cpu_offlining (+2/-2)
scripts/cpu_topology (+3/-3)
scripts/removable_storage_test (+60/-59)
scripts/run_compiz_check (+0/-27)
scripts/sleep_test (+4/-37)
scripts/watch_command (+0/-159)
setup.py (+4/-3)
lp:~roadmr/ubuntu/precise/checkbox/0.13.1-retry
Daniel Manrique (community): Needs Resubmitting
Mathieu Trudel-Lapierre: Needs Fixing
Diff: 484189 lines (+265504/-169975)
174 files modified
bin/checkbox-cli (+1/-1)
bin/checkbox-gtk (+1/-1)
bin/checkbox-urwid (+1/-1)
checkbox/lib/config.py (+3/-1)
checkbox/lib/template_i18n.py (+2/-1)
checkbox/parsers/submission.py (+8/-4)
checkbox/user_interface.py (+1/-1)
checkbox_gtk/gtk_interface.py (+8/-3)
data/whitelists/default.whitelist (+47/-21)
debian/changelog (+94/-1)
debian/checkbox-cli.postinst (+1/-0)
debian/checkbox-gtk.postinst (+1/-0)
debian/checkbox-urwid.postinst (+1/-0)
debian/control (+6/-38)
debian/hwtest-cli.postinst (+0/-6)
debian/hwtest-gtk.postinst (+0/-6)
debian/hwtest.postinst (+0/-6)
debian/hwtest.postrm (+0/-26)
debian/po/de.po (+3/-4)
debian/po/en_AU.po (+3/-4)
debian/po/en_GB.po (+4/-5)
debian/po/es.po (+5/-5)
debian/po/fr.po (+3/-4)
debian/po/he.po (+3/-4)
debian/po/hu.po (+3/-4)
debian/po/it.po (+3/-4)
debian/po/ja.po (+6/-10)
debian/po/nl.po (+3/-4)
debian/po/pl.po (+3/-4)
debian/po/pt_BR.po (+3/-4)
debian/po/ro.po (+3/-4)
debian/po/ru.po (+3/-4)
debian/po/uk.po (+118/-0)
debian/po/zh_TW.po (+4/-7)
debian/rules (+0/-6)
debian/source/format (+1/-0)
install/config (+4/-5)
install/postinst (+17/-21)
jobs/audio.txt.in (+9/-12)
jobs/bluetooth.txt.in (+6/-14)
jobs/camera.txt.in (+1/-17)
jobs/firewire.txt.in (+32/-7)
jobs/graphics.txt.in (+18/-26)
jobs/keys.txt.in (+5/-9)
jobs/local.txt.in (+1/-1)
jobs/mediacard.txt.in (+318/-158)
jobs/memory.txt.in (+5/-10)
jobs/miscellanea.txt.in (+4/-5)
jobs/monitor.txt.in (+6/-0)
jobs/networking.txt.in (+11/-2)
jobs/optical.txt.in (+1/-2)
jobs/panel_clock_test.txt.in (+1/-1)
jobs/resource.txt.in (+9/-0)
jobs/suspend.txt.in (+69/-26)
jobs/usb.txt.in (+34/-17)
jobs/user_apps.txt.in (+2/-2)
jobs/wireless.txt.in (+62/-0)
plugins/apport_prompt.py (+4/-3)
plugins/backend_info.py (+10/-0)
plugins/intro_prompt.py (+7/-5)
plugins/jobs_prompt.py (+17/-5)
plugins/launchpad_report.py (+2/-1)
plugins/recover_prompt.py (+4/-2)
plugins/shell_test.py (+1/-1)
po/POTFILES.in (+2/-0)
po/ace.po (+2170/-1770)
po/af.po (+2164/-1770)
po/am.po (+2185/-1770)
po/ar.po (+2472/-2020)
po/ast.po (+3969/-2264)
po/be.po (+3927/-1931)
po/bg.po (+2819/-2045)
po/bn.po (+2942/-1956)
po/bo.po (+2245/-1778)
po/br.po (+2339/-1806)
po/bs.po (+3856/-2116)
po/ca.po (+3234/-2211)
po/ca@valencia.po (+2964/-1997)
po/checkbox.pot (+2147/-1763)
po/ckb.po (+2192/-1774)
po/cs.po (+3938/-2404)
po/cy.po (+2156/-1771)
po/da.po (+3571/-2266)
po/de.po (+5006/-2478)
po/dv.po (+2151/-1769)
po/el.po (+4319/-2105)
po/en_AU.po (+4874/-2289)
po/en_CA.po (+2560/-1864)
po/en_GB.po (+4974/-2336)
po/eo.po (+3109/-2165)
po/es.po (+4248/-2325)
po/et.po (+2236/-1791)
po/eu.po (+2323/-1796)
po/fa.po (+2151/-1769)
po/fi.po (+3351/-2252)
po/fr.po (+4114/-2246)
po/ga.po (+2992/-0)
po/gd.po (+2125/-1739)
po/gl.po (+3802/-2056)
po/he.po (+2902/-2070)
po/hi.po (+2659/-1837)
po/hr.po (+2330/-1797)
po/hu.po (+3822/-2253)
po/hy.po (+2151/-1769)
po/id.po (+2295/-1892)
po/is.po (+2208/-1871)
po/it.po (+3970/-2446)
po/ja.po (+3387/-1984)
po/jbo.po (+2151/-1769)
po/ka.po (+2172/-1796)
po/kk.po (+2236/-1778)
po/km.po (+2151/-1769)
po/kn.po (+2176/-1770)
po/ko.po (+2712/-1858)
po/ku.po (+2167/-1770)
po/ky.po (+2151/-1769)
po/lt.po (+2333/-1776)
po/lv.po (+3318/-1899)
po/mk.po (+2250/-1891)
po/ml.po (+2160/-1769)
po/mr.po (+2163/-1769)
po/ms.po (+4978/-2213)
po/my.po (+2243/-1791)
po/nb.po (+2525/-1996)
po/nds.po (+2151/-1769)
po/ne.po (+2226/-1778)
po/nl.po (+4474/-2368)
po/nn.po (+2173/-1770)
po/oc.po (+2934/-1897)
po/pl.po (+3634/-2303)
po/ps.po (+2992/-0)
po/pt.po (+3426/-2151)
po/pt_BR.po (+4988/-2313)
po/ro.po (+2809/-2049)
po/ru.po (+5108/-2399)
po/shn.po (+2992/-0)
po/si.po (+2163/-1769)
po/sk.po (+2668/-2068)
po/sl.po (+3771/-2194)
po/sq.po (+3610/-1890)
po/sr.po (+3716/-2188)
po/sv.po (+3762/-2302)
po/ta.po (+2161/-1770)
po/te.po (+2160/-1769)
po/th.po (+2359/-1938)
po/tr.po (+3467/-2112)
po/ug.po (+3820/-2051)
po/uk.po (+2656/-1998)
po/ur.po (+2151/-1769)
po/uz.po (+2992/-0)
po/vi.po (+2629/-1875)
po/zh_CN.po (+2970/-1990)
po/zh_HK.po (+2731/-1958)
po/zh_TW.po (+2718/-1901)
scripts/audio_settings (+108/-0)
scripts/camera_test (+4/-30)
scripts/check_is_laptop (+29/-0)
scripts/compiz-check (+0/-968)
scripts/connect_wireless (+1/-1)
scripts/cpu_offlining (+2/-2)
scripts/cpu_topology (+3/-3)
scripts/create_connection (+132/-0)
scripts/media_keys_test (+275/-0)
scripts/memory_compare (+25/-0)
scripts/network_device_info (+24/-0)
scripts/network_test (+0/-24)
scripts/network_wait (+20/-0)
scripts/removable_storage_test (+144/-0)
scripts/removable_storage_watcher (+77/-0)
scripts/run_compiz_check (+0/-27)
scripts/sleep_test (+4/-37)
scripts/usb_test (+0/-143)
scripts/watch_command (+0/-159)
setup.py (+2/-2)
lp:ubuntu/precise/checkbox
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

I'll do a 'fix' for this.

Changed in checkbox-compatibility:
importance: Undecided → Low
status: New → Triaged
assignee: nobody → Brendan Donegan (brendan-donegan)
Revision history for this message
Ara Pulido (ara) wrote :

What happened with this?

Changed in checkbox-compatibility:
status: Triaged → Incomplete
Revision history for this message
Daniel Manrique (roadmr) wrote :

I see the two related merge requests as pending and "needs information", but the changes are already in latest trunk, the test appears only once and has been renamed to graphics/xorg-version.

Since this is assigned to Brendan I'll mark as Triaged again, pending a decision on whether the current manual behavior is sufficient (in which case, please mark as Fix Released) or we will further automate this test.

My $0.02 is that we needn't confuse the user with X.org versions, let's just confirm that X is running (xdpyinfo complains if that's not the case) and log the information. If xdpyinfo says "can't open display" it means that X is not running.

Changed in checkbox-compatibility:
status: Incomplete → Triaged
Revision history for this message
Jeff Lane  (bladernr) wrote :

Moved to checkbox since the tests now reside there...

affects: checkbox-compatibility → checkbox-editor
affects: checkbox-editor → checkbox
visibility: private → public
Brendan Donegan (brendan-donegan)
Changed in checkbox:
status: Triaged → In Progress
Brendan Donegan (brendan-donegan)
Changed in checkbox:
status: In Progress → Fix Committed
Marc Tardif (cr3)
Changed in checkbox:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.