Timesheet allows sign in in the future

Bug #676445 reported by Ludo (Neobis)
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Low
OpenERP R&D Addons Team 3

Bug Description

When working in the timesheet module, the workflow does not allow you to "sign in" or "out" if you are working on a timesheet in the future. However, if you manually create attendance records in the future, you can assign them to the "sign in" and "sign out" actions just fine. This can then be confirmed without any trouble.

Result is a situation where you can plan attendance on a day that has not even been here yet and confirm it as well.

Working specs:
- OpenERP 6.0 (rev 3017)
- Ubuntu server 10.04
- Addons (rev 3929)

Related branches

Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

Hello Ludo,

yes you are right, so you want to restrict the user to make attendance (sign in/out) in future ?

thanks
mra

Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Ludo (Neobis) (ludo-neobis) wrote :

Hello mra.

Yes, that was what I wanted to see. It would be good to do a date check on the attendance records you are trying to insert. Basically use the same restriction as the "sign in/ sign out" button itself.

Revision history for this message
qdp (OpenERP) (qdp) wrote :

Hello,

i do not agree with you: i don't want to have something too restricted because we often need to make manual sign in/sign out, and the buttons are not permissive at all. I'd suggest to set the o2m field of attendances on the timesheet_sheet as readonly, and let the option to do something more flexible using the menu of attendances...

thanks

Changed in openobject-addons:
importance: Medium → Low
milestone: none → 6.0-rc2
Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

Hello Ludo,

@qdp: improved as per your suggestion thanks.

Fixed the problem in Addons3.
revision-id: mra@mra-laptop-20101210061404-xs52l3jkalw87fil

Thank you,
Mustufa

Changed in openobject-addons:
status: In Progress → Fix Released
Revision history for this message
Ludo (Neobis) (ludo-neobis) wrote :

Hello mra,

I see this bug/issue has been fixed in the latest version of the server, although in my opinion this has not been fixed. Instead the problem has been shifted to another department. I see what user 'qdp' means when he thinks this is too much of a restriction, however, the actual signing in and out now needs to be done at the attendances tab. In this tab you can still sign in and out in the future, thus not solving the actual problem.

'qdp', can you think of any situation in which it is absolutely necesarry to make sign in and out actions in the future? Signing in and out in the past is a must-have in my opinion (because employees may forget to do so), and this seems to be the case now.

A small suggestion would be to use the current server date and compare it to date supplied by the user.

Furthermore, I personally don't think it is such a good idea to make the o2m field readonly, as is done now. This only spreads the functionality to more tabs.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.