rackspace-specific "cloudserversFault" name should be generic

Bug #680285 reported by Michael Gundlach
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Unassigned

Bug Description

nova/api/openstack/faults.py:50 defines "cloudServersFault" which is part of the OpenStack API response for generic faults.

"Cloud Servers" is a Rackspace product and thus the name shouldn't be in OpenStack. Use "computeFault" instead.

(Making a bug for this in case any documentation needs updating.)

Josh Kearney (jk0)
Changed in nova:
status: New → In Progress
assignee: nobody → Josh Kearney (jk0)
Josh Kearney (jk0)
Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
Eric Day (eday) wrote :

While I agree this may not be ideal, it does mean it breaks any APIs that expectt that fault name. I don't see any harm in just keeping it as is, and maybe in the next rev we can redo fault names if needed. The current OpenStack API implementation should keep it for backwards compatibility.

Revision history for this message
Josh Kearney (jk0) wrote :

Deleted my branch & merge proposal as Michael already has one with the fixes (if it's decided to use them).

Changed in nova:
status: Fix Committed → Confirmed
assignee: Josh Kearney (jk0) → nobody
status: Confirmed → New
Revision history for this message
Soren Hansen (soren) wrote : Re: [Bug 680285] Re: rackspace-specific "cloudserversFault" name should be generic

2010/11/23 Eric Day <email address hidden>:
> While I agree this may not be ideal, it does mean it breaks any APIs
> that expectt that fault name. I don't see any harm in just keeping it as
> is, and maybe in the next rev we can redo fault names if needed. The
> current OpenStack API implementation should keep it for backwards
> compatibility.

I just want to mention that I share this concern.

--
Soren Hansen
Ubuntu Developer    http://www.ubuntu.com/
OpenStack Developer http://www.openstack.org/

Revision history for this message
Michael Gundlach (gundlach) wrote :

Fix released based on LGTMs in the mergeprop.

Luckily, the name "cloudServersFault" only appears if an unknown 500 error occurs, as opposed to itemNotFoundFault for 404s, etc.

I'm not really worried, since
the number of organizations deploying Austin times
the chance of an unexpected 500 times
the chance that someone wrote a client that expects 'cloudServersFault' and uses that word when parsing a 500 times
the chance that this mis-parsing will have noticeable consequences for the customer
is rather low :)

Changed in nova:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.