[6.0][project] template project shouldn't pollute the analytic chart of account

Hello,

The fix has been committed to lp:~openerp-dev/openobject-addons/trunk-dev-addons1 with revision 4688.

It will merged into main addons soon.

Thanks.

Hello Ujjvala and Bhumika, I'm sorry to announce you that your fix is incorrect.

Instead of removing "template" account from the child_complete_ids list, it removes some "template" accounts but also some normal acounts and leave some other "template" accounts in the list.

Thie bug lies in analytic/analytic.py, in this method:

    def _child_compute(self, cr, uid, ids, name, arg, context=None):
        result = {}
        if context is None:
            context = {}

        for account in self.browse(cr, uid, ids, context=context):
            for child in account.child_ids:
                if child.state == 'template':
                    account.child_ids.pop(account.child_ids.index(child))
            result[account.id] = map(lambda x: x.id, account.child_ids)

That Python code looks rather cryptic to me, so I cannot give details here, but I guess the bug occurs because you are removing elements from the account.child_ids list while you are iterating it at the same time. I believe this doesn't work well in Python.

Here is a patch that works for me and even remove 3 lines of code.

Hope this helps

Hello Raphaël,

Thank you for your suggestions. We have applied your patch in our team branch. It will be merged into main trunk addons soon.

Thanks.