test runner permits duplicate test ids
Bug #682771 reported by
Robert Collins
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Graham Binns | ||
Bug Description
There was a testr bug recently, and in analysing it I noticed this:
"$subunit-ls < .testrepository/0 | grep distribution_txt
distribution_txt
distribution_txt
"
Unpacking that - a launchpad test run is repeating the same test id. This makes it impossible to rerun just the one test (the other same-id test will also rerun), and it means that we can't correctly index failing tests to rerun them.
I think it would be useful for the test runner to check that the test ids are unique and (initially warn, then once all are fixed, error).
Related branches
lp:~gmb/zope.testing/check-for-unique-tests
- Brad Crittenden (community): Approve (code)
-
Diff: 260 lines (+152/-6)5 files modifiedsetup.py (+1/-1)
src/zope/testing/testrunner/find.py (+38/-4)
src/zope/testing/testrunner/options.py (+16/-0)
src/zope/testing/testrunner/test_uniqueness.py (+95/-0)
src/zope/testing/testrunner/tests.py (+2/-1)
lp:~gmb/launchpad/zope.testing-p13
- j.c.sackett (community): Approve
-
Diff: 24 lines (+2/-1)2 files modifiedbuildout-templates/bin/test.in (+1/-0)
versions.cfg (+1/-1)
| Changed in launchpad-foundations: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
Revision history for this message
| Robert Collins (lifeless) wrote | #1 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| Changed in launchpad: | |
| assignee: | nobody → Gavin Panella (allenap) |
| milestone: | none → 11.04 |
| tags: | added: qa-untestable |
| Changed in launchpad: | |
| status: | Triaged → Fix Committed |
| Changed in launchpad: | |
| status: | Fix Committed → Triaged |
| assignee: | Gavin Panella (allenap) → nobody |
| milestone: | 11.04 → none |
| importance: | Medium → Low |
| tags: | removed: qa-untestable |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Graham Binns (gmb) |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #3 |
| tags: | added: qa-untestable |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I've unlinked the related branch because its only slightly related to the bug. The bug was that our test runner permits duplicates with no warning at all that this has happened.