Bazaar

bzrlib.tests.test_selftest.TestSubunitLogDetails failures with testtools trunk

Bug #683505 reported by Vincent Ladeuil
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Critical
Unassigned

Bug Description

Babune is red on all platforms when using testtools trunk (revno 149)

    * bzrlib.tests.test_selftest.TestSubunitLogDetails.test_fail_has_log
    * bzrlib.tests.test_selftest.TestSubunitLogDetails.test_unexpected_success_has_log
    * bzrlib.tests.test_selftest.TestSubunitLogDetails.test_error_has_log

based on the test names, the log is not available anymore.

A priori, since no other tests fail we may just get rid of these tests but this should be confirmed by a deeper analysis.

It's unclear at this point if the bug should be targeted at testtools for breaking an assumption of if bzr itself is making a too strong assumption.

Revision history for this message
Vincent Ladeuil (vila) wrote :

As a data point, testtools revno 130 didn't have the problem.

Revision history for this message
Robert Collins (lifeless) wrote :

Vincent, can you do the following:
 - check that bzr tip, testtools 130 is ok
 - bisect to find the failure

Thanks!

Changed in bzr:
importance: High → Critical
Revision history for this message
Vincent Ladeuil (vila) wrote :

revno 142 is the culprit: "Fix up the rest of the unexpected success issues, changing wasSuccessful
to return False after unexpected success and adding unexpected success
output to TextTestResult."

Or rather, for the tests involved, bzr assumes that a selftest run is always successful even when running a failing test...

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.