calendar overlay widget style broken after lazr-js 191 upgrade

Bug #684911 reported by Deryck Hodge
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Huw Wilkins

Bug Description

The calendar overlay widget used on many registry pages (for example, https://bugs.qastaging.launchpad.net/projects/+review-licenses) is missing some styling after the recent lazr-js upgrade. The widget still functions, though looks ugly. This is likely a simple string substitution on class names, i.e. yui3-foo for yui-foo. I haven't looked into this too much yet but will fix this up ASAP first of next week.

This bug is meant to track the need for the fix and the fact that it's a regression after the upgrade.

Related branches

Curtis Hovey (sinzui)
affects: launchpad-registry → launchpad-web
Changed in launchpad-web:
status: New → Triaged
importance: Undecided → High
Deryck Hodge (deryck)
tags: added: lazr-js-upgrade
Changed in launchpad:
importance: High → Critical
Revision history for this message
Huw Wilkins (huwshimi) wrote :

Just had a quick look and the reason it has no styles is because the YUI skin is not being applied. Applying the skin manually (i.e. adding the appropriate class name) fixes it.

I can't see anything that handles applying the skin. I assume this was happening somewhere previously if an upgrade broke it.

Revision history for this message
Deryck Hodge (deryck) wrote :

I think the classes were applied manually before the upgrade, too. This would be all the "yui-" class names. The upgraded requires that these be changed to "yui3-" so a find/replace on these strings in the calendar widget should be all that is required.

Curtis Hovey (sinzui)
Changed in launchpad:
milestone: none → 11.02
assignee: nobody → Huw Wilkins (huwshimi)
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Huw Wilkins (huwshimi)
tags: added: qa-ok
removed: qa-needstesting
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.