Mahara

notify_user() gets stuck in a loop if an admin user has disabled their email

Bug #690713 reported by Andrew Nicols
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Andrew Nicols
Mahara 1.4.0

Bug Description

A change introduced by 4ce12125c10984b946f4061e517521cbb6322389 meant that if email_user threw an exception, the admin was sent an e-mail. If an admin user has email disabled, then mahara gets stuck in an email loop trying to send them e-mail informing them of the failure.

Have fix... will push.

Revision history for this message
Andrew Nicols (dobedobedoh) wrote :

Now pushed :)

I opted for the get_class($e) option rather than catching the exception to reduce code duplication.

Changed in mahara:
assignee: nobody → Andrew Nicols (dobedobedoh)
status: New → Fix Committed
Richard Mansfield (richard-mansfield)
Changed in mahara:
milestone: 1.3.4 → 1.4.0
François Marier (fmarier)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.