Odoo Addons (MOVED TO GITHUB)

[trunk] impossible to delete a product category, even empty, if it contained products previously

Bug #698023 reported by mrshelly
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Low
OpenERP R&D Addons Team 2
Odoo Addons (MOVED TO GITHUB) 6.0

Bug Description

In product management module. Add a product, and remove it.
but, It raise an exception when I remove the product's category.

The Exception's text:
null value in column "categ_id" violates not-null constraint
CONTEXT: SQL statement "UPDATE ONLY "public"."product_template" SET "categ_id" = NULL WHERE $1 OPERATOR(pg_catalog.=) "categ_id""

I get some information from the PostgreSQL... the product.template object 's data is not be removed when the product.product object removed.

See original description

Related branches

lp:~openerp-commiter/openobject-addons/trunk-addons-aag
Atik Agewan(OpenERP) (community): Needs Resubmitting
OpenERP Core Team: Pending requested
Diff: 775 lines (+91/-131)
37 files modified
account/i18n/pt_BR.po (+2/-3)
account/report/account_balance.py (+2/-0)
account/wizard/account_move_journal.py (+1/-1)
account/wizard/account_open_closed_fiscalyear.py (+2/-0)
account/wizard/account_report_balance_sheet.py (+2/-1)
account/wizard/account_report_common.py (+4/-1)
account/wizard/account_report_general_ledger.py (+1/-1)
account/wizard/account_report_partner_balance.py (+1/-1)
account/wizard/account_report_partner_ledger.py (+1/-1)
account/wizard/account_report_profit_loss.py (+1/-1)
account/wizard/account_validate_account_move.py (+3/-0)
account/wizard/account_vat.py (+3/-0)
account_invoice_layout/i18n/hu.po (+3/-3)
auction/wizard/auction_pay_sel.py (+5/-5)
board/wizard/board_menu_create.py (+3/-3)
email_template/wizard/email_template_send_wizard.py (+10/-10)
hr_timesheet/i18n/pt_BR.po (+1/-1)
hr_timesheet/wizard/hr_timesheet_print_employee.py (+3/-1)
hr_timesheet_invoice/wizard/hr_timesheet_final_invoice_create.py (+3/-0)
mrp/i18n/es_AR.po (+2/-3)
mrp/wizard/mrp_product_produce.py (+2/-2)
pad/__openerp__.py (+1/-1)
point_of_sale/i18n/pt_BR.po (+1/-1)
project_scrum/wizard/project_scrum_backlog_create_task.py (+4/-2)
project_scrum/wizard/project_scrum_backlog_sprint.py (+3/-0)
purchase/purchase.py (+7/-4)
purchase_requisition/wizard/purchase_requisition_partner.py (+4/-5)
stock/i18n/stock.pot (+0/-5)
stock/wizard/stock_move.py (+0/-29)
stock/wizard/stock_move_view.xml (+0/-28)
stock/wizard/stock_split_move.py (+1/-1)
survey/wizard/survey_browse_answer.py (+7/-8)
survey/wizard/survey_print.py (+2/-3)
survey/wizard/survey_print_answer.py (+1/-1)
survey/wizard/survey_print_statistics.py (+1/-1)
survey/wizard/survey_selection.py (+3/-3)
survey/wizard/survey_send_invitation.py (+1/-1)
Atik Agewan(OpenERP) (community): Needs Resubmitting
Rucha (Open ERP) (community): Needs Fixing
Diff: 134 lines (+15/-11)
9 files modified
board/wizard/board_menu_create.py (+3/-1)
stock/wizard/stock_move.py (+1/-1)
stock/wizard/stock_split_move.py (+1/-1)
survey/wizard/survey_browse_answer.py (+3/-1)
survey/wizard/survey_print.py (+2/-2)
survey/wizard/survey_print_answer.py (+1/-1)
survey/wizard/survey_print_statistics.py (+1/-1)
survey/wizard/survey_selection.py (+2/-2)
survey/wizard/survey_send_invitation.py (+1/-1)
Rejected for merging into lp:openobject-addons
OpenERP Core Team: Pending requested
Diff: 513 lines (+95/-74)
16 files modified
mrp/mrp.py (+20/-2)
mrp_operations/mrp_operations.py (+8/-2)
procurement/procurement_view.xml (+3/-2)
product/pricelist.py (+4/-4)
product/product.py (+3/-3)
product/report/pricelist.py (+1/-1)
product_margin/product_margin_view.xml (+3/-0)
project_mrp/project_procurement.py (+1/-1)
purchase/purchase.py (+8/-5)
purchase/purchase_view.xml (+6/-6)
stock/stock.py (+15/-13)
stock/wizard/stock_invoice_onshipping.py (+2/-2)
stock/wizard/stock_location_product.py (+1/-1)
stock/wizard/stock_move.py (+0/-28)
stock/wizard/stock_partial_picking.py (+19/-3)
stock/wizard/stock_return_picking.py (+1/-1)
mrshelly (mrshelly)
description: updated
Revision history for this message
Azazahmed Saiyed (OpenERP) (saz-openerp) wrote :

Hello,

The traceback comes at server log every time the integrity error comes in the system.

Thanks.

Changed in openobject-server:
assignee: nobody → OpenERP's Framework R&D (openerp-dev-framework)
importance: Undecided → Low
status: New → Confirmed
Yogesh (SerpentCS) (yogesh-serpentcs)
Changed in openobject-server:
status: Confirmed → In Progress
Revision history for this message
Yogesh (SerpentCS) (yogesh-serpentcs) wrote :

Hello,

It has been fixed into https://code.launchpad.net/~openerp-dev/openobject-server/ysa-trunk-server branch by:
Revision ID: <email address hidden>
Revno: 3209

Thanks.

Changed in openobject-server:
status: In Progress → Fix Released
Yogesh (SerpentCS) (yogesh-serpentcs)
Changed in openobject-server:
milestone: none → 6.0
Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

Hello everyone,

The problem here is not the fact that there is an error message in the server console, which is totally normal and in fact helps to understand the issue.
The problem is that even after deleting all products in a given category, the category cannot be deleted because the product.templates have not been deleted and still reference it.

This needs to be fixed in the product module, for example with a custom unlink() of the product.product object, which unlink() the product.template as well if the last product.product for this template is being deleted. This way when all products in a category have been deleted, the category can be deleted too.

Workaround: create a menu to open the list of product.templates and cleanup the templates directly from there: open the product.template object via Administration>Customization>Database structure>Objects, and click on 'Create a menu'

Changed in openobject-server:
assignee: OpenERP's Framework R&D (openerp-dev-framework) → OpenERP R&D Addons Team 1 (openerp-dev-addons1)
status: Fix Released → Confirmed
affects: openobject-server → openobject-addons
Changed in openobject-addons:
milestone: 6.0 → none
summary: - null value in column "categ_id" violates
+ [trunk] impossible to delete a product category, even empty, if it
+ contained products previously
Changed in openobject-addons:
milestone: none → 6.0
Bhumika Shrimali (sbh-openerp)
Changed in openobject-addons:
assignee: OpenERP R&D Addons Team 1 (openerp-dev-addons1) → OpenERP R&D Addons Team 2 (openerp-dev-addons2)
Revision history for this message
Atik Agewan(OpenERP) (aag-openerp) wrote :

Hello mrshelly,

Thanks for reporting,
It has been fixed in lp:~openerp-commiter/openobject-addons/trunk-addons-aag
Revision ID: <email address hidden>
Revision num:5065.
It will be available in trunk soon,

Changed in openobject-addons:
status: Confirmed → In Progress
status: In Progress → Fix Committed
Rucha (Open ERP) (rpa-openerp)
Changed in openobject-addons:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.