uk vat number check problem

Bug #700962 reported by Yan-PCSol
18
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Medium
OpenERP R&D Addons Team 3

Bug Description

The check doesn't work with this valid vat number : GB102675046

Related branches

Revision history for this message
Amit Parik (amit-parik) wrote :

Hello Yan-PCSol,

Is this valid vat number?. Because i have checked this vat number but it is not valid according to me. I have refer this url http://www.eggheadcafe.com/software/aspnet/35985038/validation-of-uk-vat-number.aspx for checked the vat number.

Thanks.

Changed in openobject-addons:
status: New → Incomplete
Revision history for this message
Yan-PCSol (yannick-soldati) wrote :
Revision history for this message
Jan Stevens (janstevens) wrote : Re: [Bug 700962] Re: uk vat number check problem

Try this one:

http://ec.europa.eu/taxation_customs/vies/vieshome.do?selectedLanguage=EN

Jan Stevens
Director, Marketing & Administration

--

Op 10/01/11 11:45 schreef AMP(OpenERP) <email address hidden>:

>Hello Yan-PCSol,
>
>Is this valid vat number?. Because i have checked this vat number but it
>is not valid according to me. I have refer this url
>http://www.eggheadcafe.com/software/aspnet/35985038/validation-of-uk-
>vat-number.aspx for checked the vat number.
>
>Thanks.
>
>** Changed in: openobject-addons
> Status: New => Incomplete
>
>--
>You received this bug notification because you are a direct subscriber
>of the bug.
>https://bugs.launchpad.net/bugs/700962
>
>Title:
> uk vat number check problem
>
>Status in OpenObject Addons Modules:
> Incomplete
>
>Bug description:
> The check doesn't work with this valid vat number : GB102675046
>
>To unsubscribe from this bug, go to:
>https://bugs.launchpad.net/openobject-addons/+bug/700962/+subscribe

Revision history for this message
Amit Parik (amit-parik) wrote :

Hello,

According to comment #2 and #3 's url the above vat number is valid and in our module it is invalid. And also the our module the Uk 's vat in demo data (GB123456782) which is invalid from the above url.
So let the addons2 team will decide.

Thanks.

Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 2 (openerp-dev-addons2)
status: Incomplete → Triaged
Changed in openobject-addons:
assignee: OpenERP R&D Addons Team 2 (openerp-dev-addons2) → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
Changed in openobject-addons:
status: Triaged → Confirmed
importance: Undecided → Medium
milestone: none → 6.0
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Purnendu Singh (OpenERP) (purnendu-singh) wrote :

Hello Yan-PCSol,

We followed the link given by you http://ec.europa.eu/taxation_customs/vies/vieshome.do?selectedLanguage=EN where validation of our demo VAT failed(Old VAT number are Invalid to this link). currently we are following http://sima-pc.com/nif.php for VAT validation, which is following modules 97 algorithm.
A new series of numbers is being introduced from November 2009 for new registrations which will follow "9755" algorithm. We are looking for link where both old and new VAT numbers are validate. Can you provide us more details about the United Kingdom's VAT Calculation!!

Thanks.

Revision history for this message
Yan-PCSol (yannick-soldati) wrote :

There is a well know python package vatnumber which is copy/pasted in the OpenERP code. In the vatnumber it works then take a look in the code of the library. It would be better to use directly the library instead of copying it.

Thanks

Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

If i try with vatnumber library of python.

GB102675046 => This vat number is invalid.

Revision history for this message
Yan-PCSol (yannick-soldati) wrote :

go on google source code, the last release doesn't contain the last changes for the UK vat
http://code.google.com/p/vatnumber/

Changed in openobject-addons:
status: In Progress → Confirmed
Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

we will improve it soon.

Changed in openobject-addons:
importance: Medium → Wishlist
Revision history for this message
Yan-PCSol (yannick-soldati) wrote :

wishlist? It is blocking a company, one of our customer

Revision history for this message
qdp (OpenERP) (qdp) wrote :

fixed by the revision 4281.

thanks for the contribution

Changed in openobject-addons:
importance: Wishlist → Medium
status: Confirmed → Fix Released
Revision history for this message
Cédric Krier (cedk) wrote :

Guys, you are ridiculous by trying to maintain a copy of vatnumber in your local repository instead of using the library, you are wasting your time and the time of others because people are confused as they don't know where to report issues.
Also as you don't return patches to upstream, you don't look and don't play as a good opensource community member.

For your information vatnumber is available in most distributions:
- Debian http://packages.debian.org/search?suite=all&section=all&arch=any&searchon=names&keywords=vatnumber
- Ubuntu http://packages.ubuntu.com/search?suite=default&section=all&arch=any&searchon=names&keywords=vatnumber
- Gentoo http://hg.tryton.org/tryton-overlay/file/tip/dev-python/vatnumber

For the record the issue on vatnumber was http://code.google.com/p/vatnumber/issues/detail?id=11

Revision history for this message
Vo Minh Thu (thu) wrote :

Hi Cédric,

Thanks for calling us ridiculous :)

We are well aware of the different issues. It is planned to use (and play as a good opensource community member) the library. This is true for other libraries. Things might not move fast enough but this is planned.

Revision history for this message
Omar (Pexego) (omar7r) wrote :

Hi,

This issue persists in 5.0, you must backport it.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.