qlog crashes on svn working copy

Bug #704840 reported by Kuno Meyer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar Subversion Plugin
Fix Released
High
Jelmer Vernooij
QBzr
Fix Released
High
Gary van der Merwe

Bug Description

See traceback below.
--> Please note that "wap2" is a SVN working copy.
--> Invoking "bzr log wap2" works as intended.

bzr: ERROR: exceptions.AttributeError: 'BranchConfig' object has no attribute 'has_explicit_nickname'

Traceback (most recent call last):
  File "C:/Program Files/Bazaar/plugins\qbzr\lib\trace.py", line 300, in reports_exception_decorate
  File "C:/Program Files/Bazaar/plugins\qbzr\lib\log.py", line 233, in load
  File "C:/Program Files/Bazaar/plugins\qbzr\lib\logwidget.py", line 210, in load_locations
  File "C:/Program Files/Bazaar/plugins\qbzr\lib\loggraphprovider.py", line 362, in open_locations
  File "C:/Program Files/Bazaar/plugins\qbzr\lib\loggraphprovider.py", line 302, in branch_label
AttributeError: 'BranchConfig' object has no attribute 'has_explicit_nickname'

bzr 2.2.1 on python 2.6.4 (Windows-XP-5.1.2600-SP3)
arguments: ['bzr', 'qlog', 'wap2']
encoding: 'cp1252', fsenc: 'mbcs', lang: None
plugins:
  bzrtools C:\Program Files\Bazaar\plugins\bzrtools [2.2.0]
  colo C:\Program Files\Bazaar\plugins\colo [0.1.0]
  cvsps_import C:\Documents and Settings\mek\Application Data\bazaar\2.0\plugins\cvsps_import [unknown]
  explorer C:\Program Files\Bazaar\plugins\explorer [1.1.1]
  fastimport C:\Program Files\Bazaar\plugins\fastimport [0.9.0dev]
  launchpad C:\Program Files\Bazaar\plugins\launchpad [2.2.1]
  loom C:\Program Files\Bazaar\plugins\loom [2.2.1dev]
  netrc_credential_store C:\Program Files\Bazaar\plugins\netrc_credential_store [2.2.1]
  news_merge C:\Program Files\Bazaar\plugins\news_merge [2.2.1]
  pipeline C:\Program Files\Bazaar\plugins\pipeline [unknown]
  qbzr C:\Program Files\Bazaar\plugins\qbzr [0.19.2]
  rewrite C:\Program Files\Bazaar\plugins\rewrite [0.6.1]
  svn C:\Program Files\Bazaar\plugins\svn [1.0.4]
  upload C:\Program Files\Bazaar\plugins\upload [1.0.0dev]
  xmloutput C:\Program Files\Bazaar\plugins\xmloutput [0.8.6]

Related branches

Changed in qbzr:
importance: Undecided → High
status: New → Confirmed
Revision history for this message
Gary van der Merwe (garyvdm) wrote :

Jelmer: what do you think would be the best way to fix this: add a special case for BranchConfig's with out has_explicit_nickname (i.e. check for it with hasattr), or to add has_explicit_nickname to bzr-svn's BranchConfig? What about other foreign branch plugins.

Jelmer Vernooij (jelmer)
Changed in bzr-svn:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Jelmer Vernooij (jelmer)
milestone: none → 1.1.0
Revision history for this message
Alexander Belchenko (bialix) wrote : Re: [Bug 704840] Re: qlog crashes on svn working copy

Gary van der Merwe пишет:
> Jelmer: what do you think would be the best way to fix this: add a
> special case for BranchConfig's with out has_explicit_nickname (i.e.
> check for it with hasattr), or to add has_explicit_nickname to bzr-svn's
> BranchConfig? What about other foreign branch plugins.

Gary, I think we should provide guard code in qbzr itself against such
problem. Users may have outdated bzr-svn installed and will be affected
by this problem forever.

Just my 5 kopecks.

--
All the dude wanted was his rug back

Revision history for this message
Gary van der Merwe (garyvdm) wrote :

On 21/01/2011 10:00, Alexander Belchenko wrote:
> Gary, I think we should provide guard code in qbzr itself against such
> problem. Users may have outdated bzr-svn installed and will be affected
> by this problem forever.

Good point. I'll do that

Changed in qbzr:
milestone: none → 0.20b1
Changed in qbzr:
assignee: nobody → Gary van der Merwe (garyvdm)
status: Confirmed → Fix Released
Jelmer Vernooij (jelmer)
Changed in bzr-svn:
status: Triaged → Fix Committed
Jelmer Vernooij (jelmer)
Changed in bzr-svn:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.