[trunk][account][low] Inversion of two columns in a many2many field

Note that this should appears frequently if the documentation give 2 versions of "how make a many2many". Have a look : http://doc.openerp.com/developer/2_5_Objects_Fields_Methods/field_type.html#relational-types

First we read this :

fields.many2many('other.object.name',
                 'relation object',
                 'actual.object.id',
                 'other.object.id',
                 'Field Name')

Then we read this :

class other_object_name2(osv.osv):
    _inherit = 'other.object.name'
    _columns = {
        'other_fields': fields.many2many(
            'actual.object.name',
            'relation object',
            'actual.object.id',
            'other.object.id',
            'Other Field Name'),
    }
other_object_name2()

The other.object.id is at the fourth place, then @t third place.

Hello Olivier DOSSMANN,

Thanks for reporting.
This problem will be solved in new documentation.

Thanks.

Thanks for resolve the problem on documentation, but this bug is not only about documentation, it also affects database consistency.

To my mind it's not a standard having two inverted columns in a database. Especially if they touch account_move_lines which is very used by accountancy.

Hello Olivier,

This issue is not reproduced at our end.
Would you please update your code and recheck it?
and still problem occurred than you can reopen this bug.

Thanks.

Server: revno. 3322
Client-web: revno. 4468
Addons: revno. 4380

1. Create a new database, like test_inversion
2. Add account module
3. Create one CashBox in Bank and Cash
4. Open this CashBox, then close it.
5. Create a new one and open it
6. Create 2 cash transactions
7. Do what is necessary to close the cashbox (add some money into cashbox) then close it
8. Go to the database with "psql test_inversion"
9. Do this :
    \d account_bank_statement_line_move_rel

It returns this :
"account_bank_statement_line_move_rel_move_id_fkey" FOREIGN KEY (move_id) REFERENCES account_bank_statement_line(id) ON DELETE CASCADE
"account_bank_statement_line_move_rel_statement_id_fkey" FOREIGN KEY (statement_id) REFERENCES account_move(id) ON DELETE CASCADE

That show us that a statement_id references an account move ??? And a move_id references an account bank statement line ???

It's not a problem of integrity or function error. It's just a consistency problem.

You can easily understand that by requesting the content of the table :

    select * from account_bank_statement_line_move_rel;
    select * from account_move;
    select * from account_bank_statement_line;

Link all ids you see. They seems not to be where they should be.

The branch I put forward aims to resolve this.

Hello Olivier DOSSMANN,

I have merged your branch with the following branch:-
https://code.launchpad.net/~openerp-commiter/openobject-addons/trunk-dev-addons3-mtr1 branch.
Revision ID: mtr@mtr-20110127121721-j3i1np6ku2craczs
Revision no: 4714

Thanks for your contribution.

Thanks
mtr