xenapi_image_service flag is redundant with image_service flag

Bug #708754 reported by Thierry Carrez
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Wishlist
Brian Waldon

Bug Description

nova/virt/xenapi/vm_utils.py uses FLAGS.xenapi_image_service (values = glance or objectstore) to switch between Glance and Objectstore. It should probably use image_service instead (values = nova.image.glance.GlanceImageService or nova.image.s3.S3ImageService).

It will probably fail if one is out of sync with the other.

Related branches

Thierry Carrez (ttx)
Changed in nova:
importance: Undecided → Wishlist
status: New → Confirmed
Revision history for this message
Ewan Mellor (ewanmellor) wrote :

As per a recent thread on the mailing list, my preference would be to remove nova.image altogether, and use Glance as the abstraction between image services, rather than having that abstraction inside Nova too. (I don't think that this was unanimously agreed.)

If we did this, then we'd remove image_service altogether, which is why nova.virt.xenapi is decoupled from that.

I don't know of any problems that would arise if image_service was out of sync with xenapi_image_service -- I'm expecting xenapi_image_service to take effect when using virt.xenapi, and image_service to take effect when using virt.libvirt.

Revision history for this message
Thierry Carrez (ttx) wrote :

That's definitely another option. If we can make Glance the ultimate answer to all use cases, there is no need for a switch anymore :)

Brian Waldon (bcwaldon)
Changed in nova:
assignee: nobody → Brian Waldon (bcwaldon)
Brian Waldon (bcwaldon)
Changed in nova:
status: Confirmed → In Progress
Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → diablo-4
Thierry Carrez (ttx)
Changed in nova:
milestone: diablo-4 → 2011.3
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.