launchpad doesn't accept branches in format developer-subtree (development format 8)

Bug #709539 reported by Steve Langasek
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Won't Fix
High
Unassigned

Bug Description

Trying to push a newly-created bzr-git-based branch to launchpad fails with the following error:

$ bzr push lp:~vorlon/+junk/qemu-linaro
bzr: ERROR: Server sent an unexpected error: ('error', "'Bazaar development format 8\\n'")
$

It looks like this is because launchpad is not yet running bzr 2.3.

I have to use this format for the branch in question because the git tree I'm deriving from uses submodules.

Tags: qa-ok
Martin Pool (mbp)
Changed in launchpad:
status: New → Triaged
importance: Undecided → High
Jelmer Vernooij (jelmer)
Changed in launchpad:
status: Triaged → In Progress
assignee: nobody → Jelmer Vernooij (jelmer)
Revision history for this message
Robert Collins (lifeless) wrote :

I'm somewhat uncomfortable with LP having hosted branches of unstable formats. That seems liable to result in foot-gun events and an unpleasant user experience. IMBW.

Revision history for this message
Jelmer Vernooij (jelmer) wrote : Re: [Bug 709539] Re: launchpad doesn't accept branches in format developer-subtree (development format 8)

On Fri, 2011-05-20 at 03:42 +0000, Robert Collins wrote:
> I'm somewhat uncomfortable with LP having hosted branches of unstable
> formats. That seems liable to result in foot-gun events and an
> unpleasant user experience. IMBW.
I think that's a different discussion. Bazaar supports development
formats by default - it's just that Launchpad runs an old version of
Bazaar at at the moment.

Disabling the support for *all* development formats in the bzr running
on codehosting might be a good idea, but I think that's a different bug
than updating bzr to a newer version and updating lib/lp/code/bzr.py to
match.

I would be in favor of disabling the support for development formats -
it helps keep the repositories in experimental formats contained, as
they ought to be. If you would like me to file the appropriate bugs in
Launchpad/Bazaar for this, let me know.

Cheers,

Jelmer

Revision history for this message
Robert Collins (lifeless) wrote :

On Sat, May 21, 2011 at 1:56 AM, Jelmer Vernooij
<email address hidden> wrote:
> Disabling the support for *all* development formats in the bzr running
> on codehosting might be a good idea, but I think that's a different bug
> than updating bzr to a newer version and updating lib/lp/code/bzr.py to
> match.

I agree its a different bug, but this bug is about the use of a
development format :P.

> I would be in favor of disabling the support for development formats -
> it helps keep the repositories in experimental formats contained, as
> they ought to be. If you would like me to file the appropriate bugs in
> Launchpad/Bazaar for this, let me know.

I'm also in favour of this; perhaps you could start a (brief) thread
on bazaar + lp-dev, to find out if there are objections.

-Rob

Revision history for this message
Robert Collins (lifeless) wrote :

I ended up speaking with poolie, we agree that running development formats is a bad idea. format 8 is already in our deployed bzr - so this is deliberate.

Changed in launchpad:
status: In Progress → Won't Fix
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

On Thu, 2011-06-02 at 04:46 +0000, Robert Collins wrote:
> I ended up speaking with poolie, we agree that running development
> formats is a bad idea. format 8 is already in our deployed bzr - so this
> is deliberate.
As I mentioned, I'm also not a fan of supporting development formats on
Launchpad but I don't think the last statement is true.

The currently deployed bzr is 2.2.2, which doesn't appear to have
repository development format 8; when bzr > 2.3 lands, that will fix
this bug and allow people to push development format 8 repositories
(even though Launchpad's database may not know about the format, the
smart server will).

Cheers,

Jelmer

Revision history for this message
Robert Collins (lifeless) wrote :

Ah, the test wgrant did was faulty

:!bin/bzr init --development-subtree /tmp/foo
Created a standalone tree (format: development-subtree)

:!bzr push -d /tmp/foo lp:~lifeless/+junk/broken
Created new branch.

I'm going to open a new bug for limitin the formats used.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
Changed in launchpad:
status: Won't Fix → Fix Committed
Changed in launchpad:
status: Fix Committed → Won't Fix
assignee: Jelmer Vernooij (jelmer) → nobody
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.