Ubuntu

tla: chokes on filenames beginning with ".."

Bug #7104 reported by Scott James Remnant (Canonical)
4
Affects Status Importance Assigned to Milestone
Ubuntu
Invalid
Medium
Robert Collins

Bug Description

This isn't related to the stupid =tagging-method defaults ... tla just can't
handle filenames beginning ".." and chokes with an error like:

ExecProblem: tla exited with code 2 (expected exit codes 0 1)
argv: 'changes', '--dir',
WorkingTree('/home/scott/upstream/,,library.7825.3/drac_1.12-2.diff.gz'), '--quiet'
* error report
illegal path in changeset: ./.arch-ids/..log.id

Turns out this is hard-coded in tla, in src/tla/libfsutils/safety.c
is_non_upwards_relative_path()

      if (!str_cmp_prefix ("../", path) || !str_cmp_prefix ("..", path))
        return 0;

Revision history for this message
Matt Zimmerman (mdz) wrote :

Did you ask Robert about this?

Revision history for this message
Scott James Remnant (Canonical) (canonical-scott) wrote :

he wasn't about -- filed here because it was the only place I could think of;
probably needs assigning to him somehow

Revision history for this message
Robert Collins (lifeless) wrote :

works for me. what tla version?
robertc@lifelesslap:~/food$ tla inventory -s
....foo
robertc@lifelesslap:~/food$ tla tree-lint

Revision history for this message
Scott James Remnant (Canonical) (canonical-scott) wrote :

No, inventory works fine. Now try and make a changeset out of it and do
something with it.

The code I copied is from tla_20040718-1

Revision history for this message
Robert Collins (lifeless) wrote :

ok, got it. will fix today (fingers crossed).

Revision history for this message
Scott James Remnant (Canonical) (canonical-scott) wrote :

Moved to the other Bugzilla

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.