Odoo Addons (MOVED TO GITHUB)

[PS] pricelist types shouldn't be modifiable

Bug #715477 reported by Francois Pietquin (OpenERP)
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Low
OpenERP R&D Addons Team 2
Odoo Addons (MOVED TO GITHUB) 6.1

Bug Description

6.0.1
GTK client
ubuntu

Priceliste types : I can change the type which has an impact on the system ! Moreover, the tooltip says "keep it unchanged".
So why is it possible to change it if OpenERP advices me to not modify it?
Maybe because you would like to use intermediate pricelist which shouldn't be visible from sales orders.
ok...
I propose a drop list with the choices "sales", "purchase" and "other"
"Other" could be used in case you would like a pricelist used by another one but which couldn't be visible from a sale order.

François Pietquin
OpenERP Professional Services

See original description

Related branches

lp:~openerp-dev/openobject-addons/trunk-bug-715477-rha
Mustufa Rangwala (Open ERP) (community): Approve
Rifakat Husen (OpenERP) (community): Needs Resubmitting
Diff: 74 lines (+12/-12)
2 files modified
product/pricelist_view.xml (+5/-5)
purchase/purchase_view.xml (+7/-7)
Francois Pietquin (OpenERP) (fpi-openerp)
description: updated
summary: - pricelist types shouldn't be modifiable
+ [PS] pricelist types shouldn't be modifiable
Pieter J. Kersten (EduSense BV) (pieterj)
affects: account-banking → openobject-addons
Amit Parik (amit-parik)
Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 2 (openerp-dev-addons2)
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Rucha (Open ERP) (rpa-openerp) wrote :

Hello François,
I am not able to understand the problem,
Can you explain where you are able to change and where you want droplist?
We already have a selection box for type in pricelist form view,
and if you want to add with type other, you can simply add one type from "Sales/Configuration/Pricelists/Pricelists Types" (Fix for lp:692467),
Thanks

Changed in openobject-addons:
status: Confirmed → Invalid
Revision history for this message
Vinay Rana (OpenERP) (vra-openerp) wrote :

Hello,

I am again reopen this bug because this is really a good point to fix.
You can see the similar thing is applied for account type which is raised when the type changed to other different behavior only when It has a related account moves.

Hope this is enough for clearance.

Thanks.

Changed in openobject-addons:
status: Invalid → Confirmed
Revision history for this message
qdp (OpenERP) (qdp) wrote :

Hi,

as i don't want to loose my time anymore with that menu i find totally useless (but asked by some people), we will remove that configuration menuitem from the sales configuration and put it in an extra module called sale_pricelist_type_menu.

I don't want to hear from that anymore :-)

Thanks for your understanding,
Quentin

Mustufa Rangwala (Open ERP) (mra-tinyerp)
Changed in openobject-addons:
milestone: none → 6.1
Rifakat Husen (OpenERP) (rha-openerp)
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Rifakat Husen (OpenERP) (rha-openerp) wrote :

hello,
i have removed menu pricelists types from product module and moved to a new module sale_pricelist_type_menu.

i have fixed it in lp:~openerp-dev/openobject-addons/trunk-bug-715477-rha
Revision ID: <email address hidden>
Revision no: 4446

and new module is committed in lp:openobject-addons/extra-trunk with
Revision ID: <email address hidden>
Revision no: 5252

Thanks,
rha

Changed in openobject-addons:
status: In Progress → Fix Committed
Revision history for this message
Rifakat Husen (OpenERP) (rha-openerp) wrote :

hello,
i have removed pricelists types menu from purchase also which is fixed in
lp:~openerp-dev/openobject-addons/trunk-bug-715477-rha
Revision ID: <email address hidden>
Revision no: 4447

and committed module purchase_pricelist_type_menu in lp:openobject-addons/extra-trunk ,
which adds pricelists types menu tp purchases configuration,
Revision ID: <email address hidden>
Revision no: 5257

Thanks,
rha

Rucha (Open ERP) (rpa-openerp)
Changed in openobject-addons:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.