manager user not get hr request send by employee

Hello,

I am confirming this bug for only the issues which are given as follows.

1) We defined the "hr user" as the person who work in hr department or who is manager of a department so he has the right to approve an expense or a holiday. So he will see only his and his department 's leave requests or approve only his and his department's leave requests
  -> Now in group "Hr/user" dispaly the all employee's holidays which is wrong.

2) Only in "hr/manager" group not approved the holiday because in button of the "Approve" only set the group of hr user there is also set the hr manager group.

So in the above bug 's specification issue number 1 is invalid.
Issue number 2 is invalid because in currently the hr manager can see the all employee 's leave requests but only not approve it.
And the issue number 3 is wish-list, so I will post a new bug report as a wish-list for the issue number 3.

Thanks for the participation.

Note that it is okay if the HR/Manager does not have access to the Approve button, because we also designed the groups so that XX/Manager and XX/User are orthogonal when possible. XX/Manager needs to see dashboards, statistics, reporting, and XX/User is able to actually modify, confirm, make workflows progress and so on.
Having orthogonal groups like this allows to have manager users that can only use the reporting, because sometimes the manager is not the one that should be modifying things.
So we could say that if an HR/Manager would like to confirm himself the leave requests, he needs to have the HR/User group too.

Hello

         Thanks for information, I think there is different group to be create as there is lot of business process and functionality involved here .as we can see that for leave allocation,leave approve and leave request with two level authentication.

          If we check generalize business process lot of limitations are coming here with this two group and not able to differentiate to allocate the hr_manager group and hr_user group to any employee.

 Any buddy knows about where to define
                         3 where to define the public holidays?

Thanking you
pritesh modi

Hello Pritesh,

There is not available "define the public holidays" feature in current trunk. So we set it to as a wish-list for the future road-maps.

You can see this here :- https://bugs.launchpad.net/openobject-addons/+bug/716319

Thanks

Hello pritesh,

The problem is fixed in lp:~openerp-commiter/openobject-addons/trunk-dev-addons3-psi2.

Revision No: 4642
Revision ID: <email address hidden>

Thanks
PSI

Purnendu Singh

HR/User can also able to see its departement's member leaves.
Your diff seems working only for HR/Manager.

correct it.

Hello,

I have improve the code as suggested by mustufa rangwala and the problem is fixed in lp:~openerp-commiter/openobject-addons/trunk-dev-addons3-psi2.

Revision No: 4643
Revision ID: <email address hidden>

Thanks
PSI