Odoo Addons (MOVED TO GITHUB)

[6.0] sale.order picked_rate is wrong

Bug #725028 reported by Jacques-Etienne Baudoux
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Low
OpenERP R&D Addons Team 3
Odoo Addons (MOVED TO GITHUB) 6.1

Bug Description

Create a SO with so lines service to produce. Produce 1 of the so lines. The picked rate stays to 0.
I confirm the calculation is wrong as written in the code:
| # This is False
|- def _picked_rate(self, cr, uid, ids, name, arg, context=None):

Tags: profserv

Related branches

lp:~openerp-dev/openobject-addons/trunk-bug-725028-skh
Ujjvala Collins (community): Needs Resubmitting
qdp (OpenERP): Needs Fixing
Mustufa Rangwala (Open ERP) (community): Approve
Somesh Khare (community): Needs Resubmitting
Diff: 0 lines
Revision history for this message
Azazahmed Saiyed (OpenERP) (saz-openerp) wrote :

Hello Jacques,

I have created the SO with one line and product as service type and produce. Then install the project_mrp module which will make the task for service type product according to respected sale order. When this task will be in done state then progress bar of picked_rate will become 100 % and no longer stay with 0.

Hope you will agree with these and I am closing this bug for now.

Thanks.

Changed in openobject-addons:
status: New → Invalid
Revision history for this message
Jacques-Etienne Baudoux (jbaudoux) wrote :

Create a SO with more than 1 line.

Changed in openobject-addons:
status: Invalid → New
Revision history for this message
Azazahmed Saiyed (OpenERP) (saz-openerp) wrote :

Hello Jacques,

Thanks for the reply and correcting me. I am confirming the issue as the progress bar is not working as expected when we have a sale order of service type product with 2 lines. By confirming such SO we do have 2 related tasks in project menu. When we done one of the task the progress bar still remains in 0 but actually it must be 50% as we can see in normal product SO with partial picking scenario.

Thanks.

Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Ashvin Rathod (OpenERP) (ara-tinyerp) wrote :

Hello Jacques,

I am agree with you currently we are not updating the picked status bar when one of task got done (for the product type service). And problem also appears in stable 5.0.

So i confirm this bug and we will try to fix it soon with new version of OpenERP.

Thank you,
ara

Mustufa Rangwala (Open ERP) (mra-tinyerp)
Changed in openobject-addons:
importance: Low → Wishlist
Mustufa Rangwala (Open ERP) (mra-tinyerp)
Changed in openobject-addons:
importance: Wishlist → Low
Jacques-Etienne Baudoux (jbaudoux)
tags: added: profserv
Revision history for this message
Lucas (lucasbrosnon) wrote :

is it fixed?

Somesh Khare (somesh.khare)
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Somesh Khare (somesh.khare) wrote :

Hello Jacques-Etienne Baudoux,

I have fixed the problem in lp:~openerp-dev/openobject-addons/trunk-bug-725028-skh branch.

Revision ID: <email address hidden>
Revision No: 4607

This branch will be merged soon with Addons branch.

Thanks

Changed in openobject-addons:
status: In Progress → Fix Committed
Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

Hello Somesh,

I checked your proposal and gave the comment on it.
It does not work properly.

Can you please check and correct it ?

Thanks,
mra

Changed in openobject-addons:
status: Fix Committed → Confirmed
Revision history for this message
Somesh Khare (somesh.khare) wrote :

Hello,

I have fixed the problem in lp:~openerp-dev/openobject-addons/trunk-bug-725028-skh branch.

Revision ID: <email address hidden>
Revision No: 4609

This branch will be merged soon with Addons branch.

Thanks

Changed in openobject-addons:
status: Confirmed → In Progress
status: In Progress → Fix Committed
Mustufa Rangwala (Open ERP) (mra-tinyerp)
Changed in openobject-addons:
milestone: none → 6.1
Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

Hello somesh,

Merge proposal should be improve as per suggestion.

thanks,
mra

Changed in openobject-addons:
status: Fix Committed → Confirmed
Somesh Khare (somesh.khare)
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Somesh Khare (somesh.khare) wrote :

Hello,

I have fixed the problem in lp:~openerp-dev/openobject-addons/trunk-bug-725028-skh branch.

Revision ID: <email address hidden>
Revision No: 4612

This branch will be merged soon with Addons branch.

Thanks

Changed in openobject-addons:
status: In Progress → Fix Committed
Revision history for this message
qdp (OpenERP) (qdp) wrote :

merge proposal needs fixing, so i'm reverting it back to confirmed status

Changed in openobject-addons:
status: Fix Committed → Confirmed
Revision history for this message
Ujjvala Collins (uco-openerp) wrote :

Hello,

The fix has been committed on the linked branch: lp:~openerp-dev/openobject-addons/trunk-bug-725028-skh with revision id: 4615 <email address hidden>. This will be merged into trunk-addons soon.

Thanks Jacques-Etienne Baudoux for reporting and thanks all for the valuable contribution.

Regards,
Ujjvala

Changed in openobject-addons:
status: Confirmed → In Progress
Ujjvala Collins (uco-openerp)
Changed in openobject-addons:
status: In Progress → Fix Committed
Revision history for this message
qdp (OpenERP) (qdp) wrote :

fix released in revno 5015

Changed in openobject-addons:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.