test_network only supports VlanManager, should be renamed

Could you post the list of tests that failed, and the bzr revision you tested ?

test_network was designed to test VlanNetwork, so this is not surprising. It should probably explicitly be VlanNetworkTestCase. Tests for for FlatDHCP and Flat would be useful, but it isn't expected that the same set of tests will pass in all three modes.

Vish

On Mar 3, 2011, at 6:26 AM, Thierry Carrez wrote:

> Could you post the list of tests that failed, and the bzr revision you
> tested ?
>
> ** Changed in: nova
> Status: New => Incomplete
>
> --
> You received this bug notification because you are a member of Nova Bug
> Team, which is subscribed to OpenStack Compute (nova).
> https://bugs.launchpad.net/bugs/727522
>
> Title:
> test_network unit test cases fails for FlatDHCP/Flat network model
>
> Status in OpenStack Compute (Nova):
> Incomplete
>
> Bug description:
> I modified fake_flags.py and added following before I ran the
> test_network test.
>
> flags.DECLARE('network_manager', 'nova.network.manager')
> FLAGS.network_manager='nova.network.manager.FlatManager'
>
> following are the results after running the test_network:NetworkTestCase test.
> Ran 10 tests in 5.746s
> FAILED (errors=7, failures=2)
>
> For FlatManager, I am getting 7 errors and 2 failures.
> For FlatDHCPManager, I am getting 1 error and 4 failures.
> For VlanManager, all test cases are successful.

I agree the test_network.py testcases are written keeping view point of Vlan network Model.
Now I am separating the test cases for different network model and when you run test cases using Vlan network flag then in this case both the flat and flatDHCP network test cases will be skipped.

* test_network.py will be replaced by test_vlan_network.py (VlanNetworkTestCase)
and test_flat_network.py (FlatNetworkTestCase) and test_flatdhcp_network.py (FlatDHCPNetworkTestCase) new testcases will be added.

It's very easy to skip the test cases from python 2.7 version, I am looking out for a way to do the same in python version 2.6.5.

Excellent. That sounds like the right approach.

Vish

On Mar 3, 2011, at 11:21 AM, Tushar Patil wrote:

> I agree the test_network.py testcases are written keeping view point of Vlan network Model.
> Now I am separating the test cases for different network model and when you run test cases using Vlan network flag then in this case both the flat and flatDHCP network test cases will be skipped.
>
> * test_network.py will be replaced by test_vlan_network.py (VlanNetworkTestCase)
> and test_flat_network.py (FlatNetworkTestCase) and test_flatdhcp_network.py (FlatDHCPNetworkTestCase) new testcases will be added.
>
> It's very easy to skip the test cases from python 2.7 version, I am
> looking out for a way to do the same in python version 2.6.5.
>
> --
> You received this bug notification because you are a member of Nova Bug
> Team, which is subscribed to OpenStack Compute (nova).
> https://bugs.launchpad.net/bugs/727522
>
> Title:
> test_network unit test cases fails for FlatDHCP/Flat network model
>
> Status in OpenStack Compute (Nova):
> Invalid
>
> Bug description:
> I modified fake_flags.py and added following before I ran the
> test_network test.
>
> flags.DECLARE('network_manager', 'nova.network.manager')
> FLAGS.network_manager='nova.network.manager.FlatManager'
>
> following are the results after running the test_network:NetworkTestCase test.
> Ran 10 tests in 5.746s
> FAILED (errors=7, failures=2)
>
> For FlatManager, I am getting 7 errors and 2 failures.
> For FlatDHCPManager, I am getting 1 error and 4 failures.
> For VlanManager, all test cases are successful.

Reopening bug, adapting desc

There are now tests for FlatManager as well. Going to reject bug since it no longer applies.