Launchpad itself

Distribution:+builds timeout

Bug #739052 reported by Robert Collins
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Abel Deuring

Bug Description

  5 SELECT COUNT(*) FROM BinaryPackageBuild, BuildFarmJob, PackageBuild WHERE distro_arch_series IN ( ... dFarmJob.id AND BuildFarmJob.status=$INT AND PackageBuild.archive IN ($INT, $INT) AND ($INT=$INT):
   GET: 5 Robots: 0 Local: 2
      5 https://launchpad.net/ubuntu/+builds (Distribution:+builds)
       OOPS-1904H1, OOPS-1904H973, OOPS-1904J1734, OOPS-1904K37, OOPS-1904N531

Tags: qa-ok timeout

Related branches

lp:~adeuring/launchpad/bug-739052-8
Aaron Bentley (community): Approve
Diff: 135 lines (+70/-4)
3 files modified
lib/canonical/launchpad/webapp/batching.py (+37/-3)
lib/canonical/launchpad/webapp/tests/test_batching.py (+32/-0)
versions.cfg (+1/-1)
lp:~adeuring/launchpad/bug-739052-9
Robert Collins (community): Approve
Diff: 332 lines (+145/-25)
6 files modified
lib/canonical/launchpad/webapp/batching.py (+20/-15)
lib/canonical/launchpad/webapp/tests/test_batching.py (+38/-0)
lib/lp/soyuz/browser/build.py (+19/-2)
lib/lp/soyuz/browser/configure.zcml (+1/-1)
lib/lp/soyuz/browser/tests/test_build_views.py (+47/-0)
lib/lp/soyuz/model/binarypackagebuild.py (+20/-7)
lp:~adeuring/launchpad/bug-739052-10
Gavin Panella (community): Approve
Raphaël Badin (community): Approve (code*)
Diff: 111 lines (+53/-5)
2 files modified
lib/canonical/launchpad/webapp/batching.py (+17/-5)
lib/canonical/launchpad/webapp/tests/test_batching.py (+36/-0)
lp:~adeuring/launchpad/bug-739052-11
Brad Crittenden (community): Approve (code)
Diff: 91 lines (+20/-20)
3 files modified
lib/lp/soyuz/model/binarypackagebuild.py (+5/-4)
lib/lp/soyuz/stories/soyuz/xx-builds-pages.txt (+14/-15)
lib/lp/soyuz/stories/webservice/xx-hasbuildrecords.txt (+1/-1)
Abel Deuring (adeuring)
Changed in launchpad:
assignee: nobody → Abel Deuring (adeuring)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r13956 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13956) is part of this bug's fix.

tags: added: qa-needstesting
Changed in launchpad:
status: Triaged → In Progress
Revision history for this message
Martin Pool (mbp) wrote :

https://qastaging.launchpad.net/ubuntu/+builds seems to be consistently ok in ~0.4s

Abel Deuring (adeuring)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Abel Deuring (adeuring) wrote : Re: [Bug 739052] Re: Distribution:+builds timeout

On 16.09.2011 09:23, Martin Pool wrote:
> https://qastaging.launchpad.net/ubuntu/+builds seems to be consistently
> ok in ~0.4s
>

right that should be fast. But try
https://qastaging.launchpad.net/ubuntu/+builds?build_state=all

The core of the bug fix is still not in use: StormRangeFactory. I hope
that I can submit another MP today or early next week that finally lets
the affected view use that factory. But a few queries still need to be
hammered into the right form to match StormRangeFactory.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r14014 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/14014>.

tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
Abel Deuring (adeuring) wrote :

Marked as "qa.ok" because the latest merge, which lets the view use StormRangeFactory, works, but this is not enough to really fix the bug: The expensive COUNT(*) query is gone, but the main query to retrieve the a slice of the full result set is still slow.

tags: added: qa-ok
removed: qa-needstesting
Changed in launchpad:
status: Fix Committed → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r14033 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/14033>.

tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.