OpenStack Compute (nova)

virt.xenapi.vmops.py -> get_info should only accept a vm opaque reference

Bug #739788 reported by Trey Morris
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Unassigned

Bug Description

This will break things, like rescue, where a vm doesn't have an entry in the instances table. There are various other places in virt.xenapi.vmops where this is also true. (one thing at a time).

Related branches

lp:~ed-leafe/nova/xs-password-reset
Sandy Walsh (community): Approve
Soren Hansen (community): Approve
Trey Morris (community): Approve
Eric Day (community): Approve
Diff: 811 lines (+431/-117)
10 files modified
nova/api/openstack/servers.py (+6/-3)
nova/compute/api.py (+31/-84)
nova/compute/manager.py (+33/-0)
nova/exception.py (+4/-0)
nova/tests/test_compute.py (+7/-0)
nova/tests/test_xenapi.py (+27/-0)
nova/virt/fake.py (+17/-4)
nova/virt/xenapi/vmops.py (+174/-25)
nova/virt/xenapi_conn.py (+6/-1)
plugins/xenserver/xenapi/etc/xapi.d/plugins/agent (+126/-0)
Revision history for this message
Trey Morris (tr3buchet) wrote :

More digging. For some reason get_info is NOT consistent....

../../../nova/virt/xenapi/vmops.py: def get_info(self, instance_id):
../../../nova/virt/xenapi/vmops.py: def get_info(self, instance_id):
../../../nova/virt/xenapi/vm_utils.py: def get_info(cls, session, vm_ref):
../../../nova/virt/fake.py: def get_info(self, instance_name):
../../../nova/virt/libvirt_conn.py: def get_info(self, instance_name):
../../../nova/virt/hyperv.py: def get_info(self, instance_id):
../../../nova/virt/xenapi_conn.py: def get_info(self, instance_id):

Revision history for this message
Thierry Carrez (ttx) wrote :

Trey: Was this fixed by the linked branch merge ? If ys, please set this to Fix Committed. If not, please remove link.

Revision history for this message
Trey Morris (tr3buchet) wrote :

This will be fixed as a part of the virt/xenapi/vmops.py refactoring.

Thierry Carrez (ttx)
Changed in nova:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Mark McLoughlin (markmc) wrote :

Seems to be long fixed:

nova/virt/driver.py:103: def get_info(self, instance_name):
nova/virt/fake.py:188: def get_info(self, instance_name):
nova/virt/libvirt/connection.py:1275: def get_info(self, instance_name):
nova/virt/vmwareapi/vmops.py:665: def get_info(self, instance_name):
nova/virt/vmwareapi_conn.py:165: def get_info(self, instance_name):
nova/virt/xenapi/vmops.py:1359: def get_info(self, instance):
nova/virt/xenapi_conn.py:312: def get_info(self, instance_name):

Seems like this was the branch:

https://code.launchpad.net/~ed-leafe/nova/xs-password-reset/+merge/45537

Changed in nova:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.