Local lp: resolution could be tested against Launchpad

Bug #741633 reported by John A Meinel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Low
Unassigned

Bug Description

With fixing bug #397739 , Bazaar will now try to resolve 'lp:' style urls locally, rather than always querying the remote XMLRPC server. There are tests that it conforms to how we think it is supposed to be done. But the only definitive response is to actually make the XMLRPC request and compare the results.

We could add some tests that query Launchpad, and compare the results to the local logic. We would want these to be part of a feature that could be easily disabled.
For example, the Launchpad build machines can't actually make outside queries. So if we are running the test suite before allowing a build to be accepted into Ubuntu, we have to disable them.
Also, the tests are likely to be slow. XMLRPC seems to easily take 1s for each response. (sets up an SSL handshake, and then the round-trips for the requests.)

Most likely we'd like these tests off by default, but could enable them for something like babune.

Revision history for this message
Martin Pool (mbp) wrote : Re: [Bug 741633] [NEW] Local lp: resolution could be tested against Launchpad

One way to tackle this would be a -E test flag that gives the lp base
url to use; then the tests can skip if it's not set.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Some of the existing tests already access Launchpad - IIRC I filed a bug about this, but I can't find it at the moment.

We've disabled the launchpad plugin tests in the Debian/Ubuntu package because of this at the moment, as most buildds get run without any internet access.

Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.