Odoo Addons (MOVED TO GITHUB)

multicompany - inconsistent security rule definitions

Bug #748927 reported by Ferdinand on 2011-04-03

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Odoo Addons (MOVED TO GITHUB)	Fix Released	Low	OpenERP R&D Addons Team 2

Bug Description

IMHO either
['|',('company_id','child_of',[user.company_id.id]),('company_id','=',False)]
or
['|','|',('company_id','child_of',[user.company_id.id]),('company_id','=',False),('company_id.child_ids','child_of',[user.company_id.id])]

must be correct and be used everywhere.

It seems strange that pruchase and sale order have different company access rules

Related branches

lp:~openerp-dev/openobject-addons/trunk-bug-748927-rpa

Merged into lp:openobject-addons at revision 4756

qdp (OpenERP): Needs Information on 2011-04-20

Revision history for this message

Ferdinand (office-chricar) wrote on 2011-04-03:

multi_company.png Edit (22.7 KiB, image/png)

Amit Parik (amit-parik) on 2011-04-04

Changed in openobject-addons:
assignee:	nobody → OpenERP R&D Addons Team 2 (openerp-dev-addons2)
importance:	Undecided → Low
status:	New → Confirmed

Rucha (Open ERP) (rpa-openerp) on 2011-04-04

Changed in openobject-addons:
status:	Confirmed → In Progress

Revision history for this message

Rucha (Open ERP) (rpa-openerp) wrote on 2011-04-04:

Hello,
It has been fixed in lp:~openerp-dev/openobject-addons/trunk-bug-748927-rpa,
revno: 4621
revision-id: <email address hidden>
it will be available in trunk soon.
Thanks for reporting,

Changed in openobject-addons:
status:	In Progress → Fix Committed

Revision history for this message

Ferdinand (office-chricar) wrote on 2011-04-04:

Great -just a question - did you check this for ALL modules ?

Revision history for this message

Rucha (Open ERP) (rpa-openerp) wrote on 2011-04-05:

not for document module:
['|','|',('group_ids','in',[g.id for g in user.groups_id]), ('user_id', '=', user.id), '&', ('user_id', '=', False), ('group_ids','=',False), '|','|', ('company_id','=',False), ('company_id','child_of',[user.company_id.id]),('company_id.child_ids','child_of',[user.company_id.id])]

may be its correct as the rule is for "Read public directories",
I let the related team decide.
thanks

Changed in openobject-addons:
assignee:	OpenERP R&D Addons Team 2 (openerp-dev-addons2) → OpenERP R&D Addons Team 1 (openerp-dev-addons1)
status:	Fix Committed → Triaged