Abiword ignores DPI setting for zooming, assumes 72 dpi (1440 dpi / 20)

Bug #76396 reported by Constantine Evans
2
Affects Status Importance Assigned to Milestone
AbiWord
Fix Released
Low
abiword (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Binary package hint: abiword

Akin to bug #44672 in Evince, Abiword also ignores the system's and user's DPI settings (Xft.dpi and xorg.conf) for purposes of zooming. This was also discussed in bug #62347 in abiword, but was beyond the scope of that bug.

It appears that Abiword uses a resolution of 72 dpi for zooming, which would make sense as 72*20=1440. This should be relatively easy to fix in the GNOME and Gtk versions - I should be able to write a patch that will scale the given zoom by screen_dpi/72 to get the zoom that Abiword should use.

I will report this upstream and try to fix it later.

Changed in abiword:
status: Unknown → Confirmed
Revision history for this message
Constantine Evans (cevans) wrote :

I have a patch for this which compiles in the CVS of abiword, but the version not only aborts in feisty, but also locks up the system (probably X) to the point of complete inoperability when run under gdb. I will try with the version in feisty - my guess is that CVS version has some problems.

Changed in abiword:
assignee: nobody → cevans
Revision history for this message
Hubert Figuiere (hub) wrote :

why don't you contact upstreamm or provide the patch to them at least for review?

Changed in abiword:
status: Unconfirmed → In Progress
Revision history for this message
Constantine Evans (cevans) wrote :

A patch is now upstream, and can be easily modified to work with the version in feisty (s_getDeviceResolution already exists there, so the patch fails). However, it needs some work to get it into a reasonable state, as I don't know enough C++ - the display needs to be opened (closed) when an instance of GR_UnixGraphics is created (destroyed), instead of being done in the function as it is now, which causes a significant performance problem.

Changed in abiword:
assignee: cevans → nobody
status: In Progress → Confirmed
Changed in abiword:
status: Confirmed → In Progress
Changed in abiword:
status: In Progress → Fix Released
Revision history for this message
Constantine Evans (cevans) wrote :

A fix for this was committed upstream.

Changed in abiword:
status: Confirmed → Fix Committed
Revision history for this message
Constantine Evans (cevans) wrote :

Messed up subtle aspects of this, due on distinction of upstream/package status.

Changed in abiword:
status: Fix Committed → Confirmed
Revision history for this message
etteyafed (gdefayette) wrote :

This is fixed in >= 2.5.0 and will not be back ported, should we do it ourselves or just upgrade to 2.5.0 (or 2.5.2 soon) as it is available now?

Revision history for this message
etteyafed (gdefayette) wrote :

IMHO we might just consider upgrading even though Debian hasn't yet, they would likely accept the new version soon after we upgrade.

Revision history for this message
Hubert Figuiere (hub) wrote :

Debian does not have 2.5.x because 2.5.x is a development version. I don't recommend to package 2.5.x outside of an "experimental" repository.

Revision history for this message
Jérôme Guelfucci (jerome-guelfucci-deactivatedaccount) wrote :

I'm marking this as fix committed and we will get this as soon as 2.6.x is released.

Changed in abiword:
importance: Undecided → Low
status: Confirmed → Fix Committed
Changed in abiword:
milestone: none → later
Revision history for this message
Wouter Stomp (wouterstomp-deactivatedaccount) wrote :

Fixed: 2.6.3 is in intrepid.

Changed in abiword:
status: Fix Committed → Fix Released
Changed in abiword:
importance: Unknown → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.