Launchpad itself

bug subscription mute link is not shown for membership in a team with a direct or structural subscription

Bug #772609 reported by Brad Crittenden
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Invalid
Critical
Unassigned

Bug Description

Whether the mute link is shown on a bug page is controlled by the view property 'user_should_see_mute_link'. It does not take into account subscriptions via teams which are directly subscribed.

Recently the method Bug.personIsAlsoNotifiedSubscriber was changed to include team subscriptions via duplicate bugs but it does not include direct team subscriptions.

Related branches

lp:~bac/launchpad/bug-772609 (Merged)
lp:~gmb/launchpad/bug-772609
Abel Deuring (community): Approve (code)
Diff: 202 lines (+119/-8)
3 files modified
lib/lp/bugs/browser/bug.py (+2/-3)
lib/lp/bugs/browser/tests/test_bug_views.py (+61/-0)
lib/lp/bugs/model/bug.py (+56/-5)
lp:~gmb/launchpad/bug-772609-hopefully-without-breaking-anything-this-time
Gary Poster (community): Approve (rc)
Brad Crittenden (community): Approve (code)
Francis J. Lacoste: Pending (rc) requested
Diff: 44 lines (+19/-0)
2 files modified
lib/lp/bugs/browser/bug.py (+7/-0)
lib/lp/bugs/browser/tests/test_bug_views.py (+12/-0)
Brad Crittenden (bac)
tags: added: story-better-bug-notification
Brad Crittenden (bac)
summary: bug subscription mute link is not shown for membership in a team with a
- direct subscription
+ direct or structural subscription
Revision history for this message
Brad Crittenden (bac) wrote :

The associated branch has some tests added and some small code changes but it is not complete.

Benji York (benji)
Changed in launchpad:
assignee: Launchpad Yellow Squad (yellow) → Benji York (benji)
status: Triaged → In Progress
Benji York (benji)
Changed in launchpad:
assignee: Benji York (benji) → nobody
Revision history for this message
Graham Binns (gmb) wrote :

Whoops, forgot I needed to track this here too.

Changed in launchpad:
assignee: nobody → Graham Binns (gmb)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r13003 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13003>.

Changed in launchpad:
milestone: none → 11.05
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
William Grant (wgrant) wrote :

r13003 made getIndirectSubscribers return stuff for private bugs with duplicates with structural subscriptions (bug #780248). I'm rolling it back.

tags: added: bad-commit-13003 qa-bad
removed: qa-needstesting
Changed in launchpad:
status: Fix Committed → In Progress
William Grant (wgrant)
tags: removed: qa-bad
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r13154 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13154>.

Changed in launchpad:
milestone: 11.05 → none
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r13164 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13164>.

tags: added: qa-needstesting
removed: qa-ok
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
William Grant (wgrant) wrote :

Now it breaks either getIndirectSubscribers or getDirectSubscribers for public bugs with dupes with team subscriptions. Not sure of details yet, but try changing the status on https://bugs.qastaging.launchpad.net/launchpad/+bug/97266.

tags: added: bad-commit-13154 qa-bad
removed: qa-ok
Revision history for this message
William Grant (wgrant) wrote :

>>> getUtility(IBugSet).get(97266).default_bugtask.bug_subscribers
Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File "/srv/launchpad.net/codelines/trunk/lib/lp/bugs/model/bugtask.py", line 320, in bug_subscribers
    self.bug.getIndirectSubscribers()))
  File "/srv/launchpad.net/codelines/trunk/lib/lp/bugs/model/bug.py", line 939, in getIndirectSubscribers
    self.getSubscribersFromDuplicates(recipients, level))
  File "/srv/launchpad.net/codelines/trunk/lib/lp/bugs/model/bug.py", line 992, in getSubscribersFromDuplicates
    info.structural_subscriptions_from_duplicates.subscribers))
  File "/srv/launchpad.net/codelines/trunk/lib/lp/services/propertycache.py", line 116, in __get__
    value = self.populate(instance)
  File "/srv/launchpad.net/codelines/trunk/lib/lp/bugs/model/bug.py", line 2247, in wrapper
    return factory(func(*args, **kwargs))
  File "/srv/launchpad.net/codelines/trunk/lib/lp/bugs/model/bug.py", line 2344, in structural_subscriptions_from_duplicates
    all_duplicate_structural_subscriptions += duplicate_struct_subs
ForbiddenAttribute: ('__iadd__', [<lp.bugs.model.structuralsubscription.StructuralSubscription object at 0xdf0cdac>, <snip a few more>, <lp.bugs.model.structuralsubscription.StructuralSubscription object at 0xe45c1cc>])

Graham Binns (gmb)
Changed in launchpad:
status: Fix Committed → Triaged
importance: High → Critical
Robert Collins (lifeless)
tags: added: bad-commit-13164
removed: bad-commit-13154
tags: added: bad-commit-13154
William Grant (wgrant)
tags: added: qa-ok
removed: qa-bad
tags: removed: bad-commit-13164
Revision history for this message
Graham Binns (gmb) wrote :

I've marked this as invalid because, as far as I can tell, it's been fixed by other work. If I'm wrong, please feel free to reopen it.

Changed in launchpad:
status: Triaged → Invalid
assignee: Graham Binns (gmb) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.