Recipe build success sends emails, please stop doing that

While this is annoying, I'm setting this to LOW given the >800 HIGH bugs we currently have. But certainly, I won't be hurt if someone disagrees and marks this HIGH later. :-)

I'm going to disagree. Launchpad is sending me many hundreds of mails per week about this, most of which are essentially telling me "nothing happened" - the daily build kept working.

On Sat, May 7, 2011 at 11:40 AM, Martin Pool <email address hidden> wrote:
> I'm going to disagree.  Launchpad is sending me many hundreds of mails
> per week about this, most of which are essentially telling me "nothing
> happened" - the daily build kept working.
>

There's an even better way to disagree about the priority of a bug. :P

jml

ha ha

typical problem mail:

From: <email address hidden>
Subject: [recipe build #38225] of ~bzr bzr-daily in natty: Successfully built
Message-Id: <email address hidden>
Date: Mon, 09 May 2011 00:20:20 -0000
Reply-To: <email address hidden>
Sender: <email address hidden>
Errors-To: <email address hidden>
Precedence: bulk
X-Generated-By: Launchpad (canonical.com); Revision="12981";
 Instance="initZopeless config overlay"
X-Launchpad-Hash: 5828cf5821fce12d5ece37e4bd72c7b405fc6672

 * State: Successfully built
 * Recipe: bzr/bzr-daily
 * Archive: bzr/daily
 * Distroseries: natty
 * Duration: 19 minutes
 * Build Log: https://launchpadlibrarian.net/71396059/buildlog.txt.gz
 * Upload Log: =

 * Builder: https://launchpad.net/builders/uranium

this is generated by SourcePackageRecipeBuildMailer.

it seems to be explicitly intentionally overridden in SourcePackageRecipeBuild; does anyone think this behaviour is really good or required?

mp https://code.launchpad.net/~mbp/launchpad/778437-sprb-spam/+merge/60360

For the record, I've commented on related bugs about this before, but Ubuntu has a very strict emailing policy which is unfortunately currently hard-coded into Soyuz code (but we'll work on splitting that out at some stage as part of derived distros). However the point is that when recipe builds start getting used for Ubuntu we need to make sure the policy is carefully followed or there will be a lot of angry people! For reference, most of the code is in lib/lp/soyuz/mode/queue.py

It looks like this test changed during <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/devel/revision/11566> done for <https://bugs.launchpad.net/launchpad/+bug/506256> when it changed from asserting that mail was sent once to asserting it is not sent at all. I guess the mail is now actually sent through some other path but I can't work out what that is.

Fixed in stable r13067 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13067>.