Launchpad itself

import policy violations in gina

Bug #78598 reported by Elliot Murphy
0
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Undecided
Unassigned

Bug Description

When I run 'python test.py -fvvv canonical gina', I see 8 import policy violations.
I've already reported bug 78452 about ftpmaster, this bug is about the other 7 violations in canonical.launchpad.scripts.gina.handlers.

Here is a paste of the violations:

There were 2 database import violations.
You should not import canonical.launchpad.database into:
    canonical.launchpad.scripts.gina.handlers
You should not import canonical.launchpad.database.publishing into:
    canonical.launchpad.scripts.ftpmaster

There were 6 imports of names not appearing in the __all__.
You should not import PoolFileNotFound from canonical.launchpad.scripts.gina.packages:
    canonical.launchpad.scripts.gina.handlers
You should not import get_dsc_path from canonical.launchpad.scripts.gina.packages:
    canonical.launchpad.scripts.gina.handlers
You should not import licence_cache from canonical.launchpad.scripts.gina.packages:
    canonical.launchpad.scripts.gina.handlers
You should not import prioritymap from canonical.launchpad.scripts.gina.packages:
    canonical.launchpad.scripts.gina.handlers
You should not import read_dsc from canonical.launchpad.scripts.gina.packages:
    canonical.launchpad.scripts.gina.handlers
You should not import urgencymap from canonical.launchpad.scripts.gina.packages: canonical.launchpad.scripts.gina.handlers
Exception exceptions.TypeError: "'NoneType' object is not callable" in <bound method Transaction.__del__ of <sqlobject.dbconnection.Transaction object at 0x3d266d0>> ignored

Revision history for this message
Elliot Murphy (statik) wrote :

moving to launchpad product instead of launchpad development infrastructure

Revision history for this message
Gary Poster (gary) wrote :

No idea when this changed, but the following test seems well-behaved.

$ ./bin/test -vvt gina
Running tests at level 1
Running canonical.testing.layers.LaunchpadFunctionalLayer tests:
  Set up canonical.testing.layers.BaseLayer in 0.210 seconds.
  Set up canonical.testing.layers.DatabaseLayer in 0.344 seconds.
  Set up canonical.testing.layers.LibrarianLayer in 6.108 seconds.
  Set up canonical.testing.layers.LaunchpadLayer in 0.000 seconds.
  Set up canonical.testing.layers.FunctionalLayer in 4.492 seconds.
  Set up canonical.testing.layers.GoogleServiceLayer in 1.533 seconds.
  Set up canonical.testing.layers.LaunchpadFunctionalLayer in 0.000 seconds.
  Running:
 lib/lp/soyuz/tests/../doc/gina-multiple-arch.txt
 lib/lp/soyuz/tests/../doc/gina.txt
  Ran 61 tests with 0 failures and 0 errors in 1 minutes 27.976 seconds.
Tearing down left over layers:
  Tear down canonical.testing.layers.LaunchpadFunctionalLayer in 0.000 seconds.
  Tear down canonical.testing.layers.LaunchpadLayer in 0.000 seconds.
  Tear down canonical.testing.layers.LibrarianLayer in 0.538 seconds.
  Tear down canonical.testing.layers.GoogleServiceLayer in 0.071 seconds.
  Tear down canonical.testing.layers.FunctionalLayer ... not supported
  Tear down canonical.testing.layers.DatabaseLayer in 0.024 seconds.
  Tear down canonical.testing.layers.BaseLayer in 0.000 seconds.

Changed in launchpad-foundations:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.