mitigate bash-ism of novarc.template
Bug #787351 reported by
Isaku Yamahata
This bug affects 3 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenStack Compute (nova) |
Fix Released
|
Low
|
Unassigned | ||
Bug Description
wishlist: novarc.template uses BASH_SOURCE which is very specific to bash.
It can be mitigated a bit by ${BASH_SOURCE:-$0} so that other bsh-like shell,
ksh, zsh, dash.
Related branches
Revision history for this message
| Soren Hansen (soren) wrote Re: [Bug 787351] [NEW] mitigate bash-ism of novarc.template | #1 |
| Changed in nova: | |
| assignee: | nobody → Isaku Yamahata (yamahata) |
| importance: | Undecided → Low |
| status: | New → In Progress |
Revision history for this message
| Thierry Carrez (ttx) wrote | #2 |
Revision history for this message
| Mark McLoughlin (markmc) wrote | #3 |
| Changed in nova: | |
| assignee: | Isaku Yamahata (yamahata) → nobody |
| status: | In Progress → Confirmed |
Revision history for this message
| Thierry Carrez (ttx) wrote | #4 |
| Changed in nova: | |
| status: | Confirmed → Fix Released |
To post a comment you must log in.
2011/5/24 Isaku Yamahata <email address hidden>:
> Public bug reported:
>
> wishlist: novarc.template uses BASH_SOURCE which is very specific to bash.
> It can be mitigated a bit by ${BASH_SOURCE:-$0} so that other bsh-like shell,
> ksh, zsh, dash.
That will only fix it for zsh. For bash, dash and ksh, $0 contains the
name of the command that is currently being executed. novarc is
*sourced*, not execve'd. The fact that $0 works for zsh is a zshism.
I'm ok with the change, I'm just saying. :)
--
Soren Hansen | http://
Ubuntu Developer | http://
OpenStack Developer | http://