Odoo Addons (MOVED TO GITHUB)

Missing multi-company access rules

Bug #788139 reported by Ferdinand
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Low
OpenERP R&D Addons Team 2

Bug Description

Analytic Journal Items must be restricted using

['|',('company_id','=',False),('company_id','child_of',[user.company_id.id])]

Related branches

lp:~openerp-dev/openobject-addons/trunk-bug-788139-mtr
Mustufa Rangwala (Open ERP) (community): Approve
Meera Trambadia (OpenERP) (community): Needs Resubmitting
qdp (OpenERP): Pending requested
Diff: 182 lines (+89/-4)
9 files modified
account_analytic_default/__openerp__.py (+5/-1)
account_analytic_default/security/account_analytic_default_security.xml (+13/-0)
account_followup/__openerp__.py (+1/-0)
account_followup/security/account_followup_security.xml (+20/-0)
analytic/security/analytic_security.xml (+8/-0)
hr/security/hr_security.xml (+15/-3)
hr_evaluation/security/hr_evaluation_security.xml (+15/-0)
hr_expense/security/ir_rule.xml (+6/-0)
hr_recruitment/security/hr_recruitment_security.xml (+6/-0)
lp:~openerp-dev/openobject-addons/trunk-bug-788139-ron
Rohan Nayani(Open ERP) (community): Needs Resubmitting
Rucha (Open ERP) (community): Needs Fixing
qdp (OpenERP): Pending requested
Diff: 160 lines (+82/-4)
7 files modified
mrp/security/mrp_security.xml (+14/-0)
product/security/product_security.xml (+10/-3)
stock/security/stock_security.xml (+14/-0)
stock_location/__openerp__.py (+1/-1)
stock_location/security/stock_location_security.xml (+21/-0)
stock_planning/__openerp__.py (+1/-0)
stock_planning/security/stock_planning_security.xml (+21/-0)
Revision history for this message
Ferdinand (office-chricar) wrote :

same for "Analytic Journal"

Revision history for this message
Ferdinand (office-chricar) wrote :

here is a statement which lists all models without company access domain.

IMHO all models accessible from menu must have such a rule as default.

select m.model,m.name from ir_model m
 where id not in (select model_id from ir_rule i where domain_force like '%company_id%')
   and id in (select model_id from ir_model_fields where name = 'company_id')
order by 1;

Amit Parik (amit-parik)
Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
importance: Undecided → Low
status: New → Confirmed
Meera Trambadia (OpenERP) (mtr-openerp)
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Meera Trambadia (OpenERP) (mtr-openerp) wrote :

Hello Ferdinand,

Its fixed in https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-788139-mtr branch.
Revision ID: mtr@mtr-20110608072935-blig6ejq1oa36un5
Revision no: 4771

Thank you for the query to track the models without multi-company access rules.

I have assigned the rules for the account_followup, account_analytic_default, analytic ,hr, hr_evaluation, hr_expense,hr_recruitment modules.

@ Community team: In order to assign the rules to all the models,it should be assigned to the respective addons team.

Thanks,
mtr

Meera Trambadia (OpenERP) (mtr-openerp)
Changed in openobject-addons:
status: In Progress → Fix Committed
Meera Trambadia (OpenERP) (mtr-openerp)
Changed in openobject-addons:
status: Fix Committed → Confirmed
Amit Parik (amit-parik)
Changed in openobject-addons:
assignee: OpenERP R&D Addons Team 3 (openerp-dev-addons3) → OpenERP R&D Addons Team 2 (openerp-dev-addons2)
Rohan Nayani(Open ERP) (ron-tinyerp)
Changed in openobject-addons:
status: Confirmed → In Progress
Rohan Nayani(Open ERP) (ron-tinyerp)
summary: - account analytic line needs multicompany access rule
+ stock modules needs multicompany access rule
Revision history for this message
Rohan Nayani(Open ERP) (ron-tinyerp) wrote : Re: stock modules needs multicompany access rule

Hello,

Thanks for Reporting.
It has been fixed in lp:~openerp-dev/openobject-addons/trunk-bug-788139-ron
Revision ID: <email address hidden>
Revision num:4772.

It will be available in trunk soon.
Thank you for the query

I have assigned the rules for the product,mrp,stock,stock_location,stock_planning modules.

Thanks

Changed in openobject-addons:
status: In Progress → Fix Committed
Rucha (Open ERP) (rpa-openerp)
summary: - stock modules needs multicompany access rule
+ Missing multi-company access rules
Fabien (Open ERP) (fp-tinyerp)
Changed in openobject-addons:
status: Fix Committed → Fix Released
Revision history for this message
qdp (OpenERP) (qdp) wrote :

merged at revision 5062 revid:<email address hidden> and 5063 revid:<email address hidden>

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.