Odoo Addons (MOVED TO GITHUB)

[6.0] Employee Timesheet report misuse unit factor

Bug #788297 reported by Stéphane Bidoul (Acsone)
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Low
OpenERP R&D Addons Team 3

Bug Description

Hi,

In the 6.0 series, the Employee(s) Timesheet report show incorrect results.

Steps to reproduce:
- openerp 6 with demo data
- create a new timesheet
- add a line with 8 hours
- run Employee Timesheet report -> 64 hours displayed

Expected result: 8 hours displayed in report.

Best regards,

-sbi

Related branches

lp:~openerp-dev/openobject-addons/trunk-bug-788297-mtr
Mustufa Rangwala (Open ERP) (community): Approve
Meera Trambadia (OpenERP) (community): Needs Resubmitting
qdp (OpenERP): Pending requested
Diff: 25 lines (+2/-2)
2 files modified
hr_timesheet/report/user_timesheet.py (+1/-1)
hr_timesheet/report/users_timesheet.py (+1/-1)
Revision history for this message
Edwin Dsouza(OpenERP) (eds-openerp) wrote :

Hello,

I have checked your issue at my end and I have faced the same problem. I am bit confused about why the line hours are multiplied by 8, i.e if I add 8 hours work, than in the employee time_sheet report it shows 64 hours. So I'll like to know for what purpose are the hours multiplied by 8 ?

Thank you.

Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Stéphane Bidoul (Acsone) (sbi) wrote :

Hi,

I believe the intent was to print the timesheet using the reference unit. In which case the quantity should be devided by the factor and not multiplied.

Proposed patch attached.

Best regards,

-sbi

Meera Trambadia (OpenERP) (mtr-openerp)
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Meera Trambadia (OpenERP) (mtr-openerp) wrote :

Hello Stéphane Bidoul,

Its fixed in https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-788297-mtr branch.
Revision ID: mtr@mtr-20110613062321-z23jvc1z5my3q08b
Revision no: 4780

We have checked your patch but couldn't apply it as we just need to show the quantity on report.
Thank you for your time and effort.

Thanks,
mtr

Changed in openobject-addons:
status: In Progress → Fix Committed
Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

Hello Meera,

Patch from your Merge proposal is not consistent with all UOM categories.

But proposed patch by Stéphane seems correct as we should divide the factor so that it can consider reference UOM of that categories.
Can you please apply and test the patch.

Thanks Stéphane for the contribution,
mra

Changed in openobject-addons:
status: Fix Committed → Confirmed
Meera Trambadia (OpenERP) (mtr-openerp)
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Meera Trambadia (OpenERP) (mtr-openerp) wrote :

Hello mra,

I have applied the patch proposed by Stéphane.

Its fixed in https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-788297-mtr branch.
Revision ID: mtr@mtr-20110621095117-69bkgohrkkwv5n01
Revision no: 4781

Thanks Stéphane for the patch.

Thanks,
mtr

Changed in openobject-addons:
status: In Progress → Fix Committed
Revision history for this message
Massimo Biancalani (massimo-biancalani) wrote :

Hi,
For my point of view, the report should prompt the quantities in the associated unit of measure of product (i.e. Service on Timesheet).
For instance if a user insert 3 hours on a analytic account it's confusing displaying 0,375, but it's correct to display 3 hours.

Proposed patch attached.

Best regards,

Fabien (Open ERP) (fp-tinyerp)
Changed in openobject-addons:
status: Fix Committed → Fix Released
Revision history for this message
qdp (OpenERP) (qdp) wrote :

merged at revision 5067

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.