[Trunk] hr_attendance can not install

Bug #791087 reported by Amit Parik
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
High
OpenERP R&D Addons Team 3

Bug Description

Addons rev no: 4759.

When I install the hr_attendance module I found the following traceback and module can not install .

_attendance/hr_attendance_demo.xml:125:
<record id="attendance21" model="hr.attendance">
            <field eval="time.strftime('%Y-%m-%d 10:00')" name="name"/>
            <field name="action">sign_in</field>
            <field name="employee_id" ref="hr.employee1"/>
        </record>
Traceback (most recent call last):
  File "/home/tiny/workspace/openobject-server/openerp/tools/convert.py", line 885, in parse
    self._tags[rec.tag](self.cr, rec, n)
  File "/home/tiny/workspace/openobject-server/openerp/tools/convert.py", line 852, in _tag_record
    id = self.pool.get('ir.model.data')._update(cr, self.uid, rec_model, self.module, res, rec_id or False, not self.isnoupdate(data_node), noupdate=self.isnoupdate(data_node), mode=self.mode, context=rec_context )
  File "/home/tiny/workspace/openobject-server/openerp/addons/base/ir/ir_model.py", line 690, in _update
    res_id = model_obj.create(cr, uid, values, context=context)
  File "/home/tiny/workspace/openobject-addons/hr_timesheet_sheet/hr_timesheet_sheet.py", line 614, in create
    res = super(hr_attendance,self).create(cr, uid, vals, context=context)
  File "/home/tiny/workspace/openobject-server/openerp/osv/orm.py", line 3893, in create
    self._validate(cr, user, [id_new], context)
  File "/home/tiny/workspace/openobject-server/openerp/osv/orm.py", line 1106, in _validate
    raise except_orm('ValidateError', '\n'.join(error_msgs))
except_orm: ('ValidateError', u'Error occurred while validating the field(s) action: Error: Sign in (resp. Sign out) must follow Sign out (resp. Sign in)')

Related branches

Amit Parik (amit-parik)
Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
importance: Undecided → High
status: New → Confirmed
ArtERP.ru (trokbrok)
Changed in openobject-addons:
status: Confirmed → Incomplete
status: Incomplete → Confirmed
Changed in openobject-addons:
status: Confirmed → In Progress
Changed in openobject-addons:
status: In Progress → Confirmed
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Meera Trambadia (OpenERP) (mtr-openerp) wrote :

Hello Amit,

Its fixed in https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-791087-mtr branch.
Revision ID: mtr@mtr-20110607072452-0bfof7uii2cirleq
Revision no: 4771.

It will be merged soon with trunk-addons.

Thanks,
mtr

Changed in openobject-addons:
status: In Progress → Fix Committed
Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

Hi,

I'm resetting the bug to Confirmed, as I think we can do much better than the proposed solution (see the merge proposal for a comment explaining why)

We have many cases where demo data are being constructed without properly caring about all the cases and the time of the creation of the database - this needs to be considered more seriously.

Thanks!

Changed in openobject-addons:
status: Fix Committed → Confirmed
Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

Note: I temporarily commented out the conflicting records in hr_attendance/hr_attendance_demo.xml, until this is properly fixed, to avoid crashes during installation (this is not a proper fix, just a workaround!)

Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Meera Trambadia (OpenERP) (mtr-openerp) wrote :

Hello,

I have replaced XML demo file with yaml demo file as suggested by odo.

Its fixed in https://bugs.launchpad.net/openobject-addons/+bug/791087 branch.
Revision ID: mtr@mtr-20110711052421-ngn6csywtc4xx4p3
Revision no: 4772

Thanks odo for your valuable suggestion.

Thanks,
mtr

Changed in openobject-addons:
status: In Progress → Fix Committed
Changed in openobject-addons:
status: Fix Committed → Fix Released
milestone: none → 6.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.